Color picker UX - allow swicth mode on canvas#19827
Merged
Conversation
Also introduce type dt_pickerpoint_t to store simple picker point.
Use the newly introduced routine to set the default which can be controlled in a single routine.
Again to ensure the default is set at a single point.
Ensure that the point position is preserved by using a new dt_pickerpoint_t variable (pdrag) when dragging a box corner. This also make it possible to swicth between point/area for all pickers. Closes #17887
TurboGit
added
priority: medium
Member
Author
|
@jenshannoschwalm : I finally got it :) |
|
It seems that this is causing major issue with area selection in all modules I tested (exposure, color balance, white balance, negadoctor, agx, etc.). I am on Windows 11. I am no longer able to precisely select an area with the picker using click and drag. Selected area is now a random sized rectangle. I had to revert back to commit 456a4b7. |
Member
Author
|
Can you please open an issue? TIA. |
1 task
Done: issue #20299 |
elstoc
added
documentation-complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow Ctrl+Clik on canvas to switch between picker point/area.
Ensure that the point position is preserved by using a new
variable (pdrag) when dragging a box corner.
This rework also make it possible to switch between point/area for all pickers.
Also use routine to initialize the picker point/area default at a single place. Better than having
the same code duplicated in many places.
Rework the picker initialization that do not require anymore a check for some values as the
picker point/area are now always initialized at creation time.
Finally a new type
dt_pickerpoint_tis introduce to store position of apicker point (we already add
dt_pickerbox_tfor an area).Closes #17887