Keep applied preset name marked with asterix after changes#19959
Closed
dterrahe wants to merge 1 commit intodarktable-org:masterfrom
Closed
Keep applied preset name marked with asterix after changes#19959dterrahe wants to merge 1 commit intodarktable-org:masterfrom
dterrahe wants to merge 1 commit intodarktable-org:masterfrom
Conversation
dterrahe
added
the
priority: low
TurboGit
added
feature: enhancement
Member
|
@dterrahe : This needs conflict resolution. TIA. |
TurboGit
added
documentation-pending
Contributor
|
@elstoc this has the |
TurboGit
removed
documentation-pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements suggestion in https://discuss.pixls.us/t/small-improvement-in-modules-instance-naming/54795/4
When a preset is applied to a module, it's name is added as the instance name to the module (if one wasn't set manually). Then when any change is made, the instance name is reset to empty, This PR keeps the name of the last applied preset as the instance name, but marks it with an asterix if any further changes are made.
Other ways of marking (different prefix or postfix characters) can be easily implemented in
dt_util_localize_segmented_nameeven when internally keeping the "*" prefix (which doesn't conflict with translation markers; postfix markers would be more complicated to deal with internally).This also includes the simplifications of
dt_util_localize_segmented_namesuggested here #19459 (comment)