-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Safe starting without splash #20116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Safe starting without splash #20116
Conversation
d4d84be to
6ff5d07
Compare
|
@wpferguson would you be able to test for #19992 |
6ff5d07 to
23d576d
Compare
|
It's still crashing for me. Before this PR I noticed that sometimes dt starts one time, but after that it will crash every single start. |
|
Thanks for feedback! What do you mean with crashing exactly? No window appearing without further notice in the logs? |
dterrahe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies; I had a couple of pending comments lined up as in the other PR, but as usual forgot to press the "Finish your review" button.
23d576d to
5d107a9
Compare
TurboGit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor change.
Also, given the last comment that this seems to not fix the splash issue I suppose we want this in 5.6 but not in 5.4.1. Right?
5d107a9 to
4e9aab8
Compare
Sorry for the late reply. Dt starts but as soon as the GUI tries to start, it just keeps a spinning blue circle. Nothing new in the logs after that point. There is an X close button on the top right. When press it, Windows tells me that the app crashed and it closes everything. Log remains the same. |
…0002' As discussed there this was not a fix and added misleading code, so let's revert. Also removed the pthread naming for the jobs as it didn't work correctly and we have the jobs logged anyway.
It's now implemented as an inline function checking for darktable.control == NULL, if so write caller, file and position to the logs. control-last_expose_time was not used at all so it got removed.
Don't clear *gui struct again - it was calloced, a few things have been set up already and we want to keep that.
4e9aab8 to
69da479
Compare
Avoid control threads race conditionAvoid control threads race condition #20002dt_control_running()as an inline function checking fordarktable.controlpossibly logging an errorcontrol->last_expose_timewas not used at all so it got removed.*gui structagaindt_gui_gtk_init()