Skip to content

Conversation

@jenshannoschwalm
Copy link
Collaborator

  1. Manually reverts Avoid control threads race condition Avoid control threads race condition #20002
  2. Removed the pthread naming for the jobs as it didn't work correctly
  3. Redefine dt_control_running() as an inline function checking for darktable.control possibly logging an error
  4. control->last_expose_time was not used at all so it got removed.
  5. Don't clear *gui struct again
  6. Give Gtk a chance to update the screen late in dt_gui_gtk_init()

@jenshannoschwalm
Copy link
Collaborator Author

@wpferguson would you be able to test for #19992
@dterrahe you absolutely convinced me :-) Would you review ?

@gi-man
Copy link
Contributor

gi-man commented Jan 10, 2026

It's still crashing for me. Before this PR I noticed that sometimes dt starts one time, but after that it will crash every single start.

@jenshannoschwalm
Copy link
Collaborator Author

jenshannoschwalm commented Jan 10, 2026

Thanks for feedback! What do you mean with crashing exactly? No window appearing without further notice in the logs?

Copy link
Member

@dterrahe dterrahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies; I had a couple of pending comments lined up as in the other PR, but as usual forgot to press the "Finish your review" button.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change.

Also, given the last comment that this seems to not fix the splash issue I suppose we want this in 5.6 but not in 5.4.1. Right?

@TurboGit TurboGit added this to the 5.6 milestone Jan 14, 2026
@TurboGit TurboGit added the scope: codebase making darktable source code easier to manage label Jan 14, 2026
@gi-man
Copy link
Contributor

gi-man commented Jan 14, 2026

Thanks for feedback! What do you mean with crashing exactly? No window appearing without further notice in the logs?

Sorry for the late reply. Dt starts but as soon as the GUI tries to start, it just keeps a spinning blue circle. Nothing new in the logs after that point. There is an X close button on the top right. When press it, Windows tells me that the app crashed and it closes everything. Log remains the same.

…0002'

As discussed there this was not a fix and added misleading code, so let's revert.
Also removed the pthread naming for the jobs as it didn't work correctly and we have the
jobs logged anyway.
It's now implemented as an inline function checking for darktable.control == NULL, if so
write caller, file and position to the logs.

control-last_expose_time was not used at all so it got removed.
Don't clear *gui struct again - it was calloced, a few things have been set up already
and we want to keep that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: codebase making darktable source code easier to manage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants