AgX refactoring and preset changes by kofa73 · Pull Request #20120 · darktable-org/darktable

agx: Fix crash during initialisation caused by callback triggered before all controls created; also: remove redundant soft limits (matching hard limits)

kofa73

committed

agx: Remove custom 'initialized' field, rely on darktable.gui->reset for protection

kofa73

committed

agx: No need for darktable.gui->reset in gui_init, as it's handled by imageop#dt_iop_gui_init

kofa73

committed

agx: Don't call gui_update at the end of gui_init; add _update_curve_warnings to gui_update so initial state is painted correctly

kofa73

committed

agx: Don't call gui_changed from gui_update; extract all dynamic redraws into function _update_redraw_dynamic_gui, called from gui_update and gui_changed; extract slider offset, scale, default and …

kofa73

committed

agx: don't use float MIN/MAX for gboolean params

kofa73

committed

agx: don't hide primaries selection if 'disable adjustments' is checked (the idea is to disable (un)rotations and attenuation/purity boost only); use 60% hue preservation for Blender defaults (as t…

kofa73

committed

agx: create 'reset primaries' with dt_ui_label_new instead of gtk_label_new

kofa73

committed

agx: call gui_changed at the end of gui_update; it takes care of calling _update_redraw_dynamic_gui

kofa73

committed

agx: US spelling of 'color'

kofa73

committed

agx: adjusted default params to be closer to sigmoid's; added sigmoid-like presets

kofa73

committed

agx: sync contrast, toe and shoulder power slider defaults with scene-referred default values

kofa73

committed

agx: slight tooltip wording change to make it clear the warning does not indicate an error that must be fixed

kofa73

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

AgX refactoring and preset changes#20120

AgX refactoring and preset changes#20120
kofa73 wants to merge 13 commits intodarktable-org:masterfrom
kofa73:agx-various-fixes

Commits on Jan 10, 2026

agx: Fix crash during initialisation caused by callback triggered before all controls created; also: remove redundant soft limits (matching hard limits)

agx: Remove custom 'initialized' field, rely on darktable.gui->reset for protection

agx: No need for darktable.gui->reset in gui_init, as it's handled by imageop#dt_iop_gui_init

agx: Don't call gui_update at the end of gui_init; add _update_curve_warnings to gui_update so initial state is painted correctly

agx: Don't call gui_changed from gui_update; extract all dynamic redraws into function _update_redraw_dynamic_gui, called from gui_update and gui_changed; extract slider offset, scale, default and …

agx: don't use float MIN/MAX for gboolean params

agx: don't hide primaries selection if 'disable adjustments' is checked (the idea is to disable (un)rotations and attenuation/purity boost only); use 60% hue preservation for Blender defaults (as t…

agx: create 'reset primaries' with dt_ui_label_new instead of gtk_label_new

agx: call gui_changed at the end of gui_update; it takes care of calling _update_redraw_dynamic_gui

agx: US spelling of 'color'

agx: adjusted default params to be closer to sigmoid's; added sigmoid-like presets

agx: sync contrast, toe and shoulder power slider defaults with scene-referred default values

agx: slight tooltip wording change to make it clear the warning does not indicate an error that must be fixed