agx: clarify in toe/shoulder warning#20133
Closed
kofa73 wants to merge 1 commit intodarktable-org:masterfrom
Closed
agx: clarify in toe/shoulder warning#20133kofa73 wants to merge 1 commit intodarktable-org:masterfrom
kofa73 wants to merge 1 commit intodarktable-org:masterfrom
Conversation
…ot an error condition, the module is still working fine
Contributor
Author
|
@TurboGit: trying to send smaller, more focused PRs to be merged to master later |
ralfbrown
reviewed
Jan 12, 2026
| "without inverting the shoulder (forcing it to bend upwards), it would be\n" | ||
| "impossible to reach target white with the selected contrast and pivot position.\n" | ||
| "this is not an error, the module is still working correctly.\n" | ||
| "if you see artifacts, or wish to regain control over the shoulder, try the following:\n" |
Collaborator
There was a problem hiding this comment.
See also #20040. I'd recommend turning this final paragraph into a bullet list for readability.
TurboGit
added
feature: enhancement
Member
|
Needs conflict resolution. TIA. |
Contributor
Author
|
Superseded by #20040 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooltip update to address misunderstandings