Skip to content

Conversation

@Dave22152
Copy link
Contributor

Adds description of new tag icon in lighttable thubnails and also adds descriptions of group and history icons which don't seem to be addressed elsewhere

Refers to DT PR 18297


Certain icons are displayed on thumbnails to provide additional information on images, when applicable

Images that are members of a group are denoted by a group icon ![light group icon](./thumbnails/Group-icon-light.png#icon) or ![dark group icon](./thumbnails/Group-icon-black.png#icon), where black identifies the leader image in that group. See [image grouping](https://github.com/Dave22152/dtdocs/blob/master/content/lighttable/digital-asset-management/grouping.md) for details
Copy link
Contributor

@elstoc elstoc Apr 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this linking to your own github repo?

@elstoc
Copy link
Contributor

elstoc commented Apr 13, 2025

The images in this PR are a little too small for legible display on the website. You may be able to extract larger images by increasing your DPI and/or font size. Ideally the borders around these images should be as small as possible (again, for better legibility)

@Dave22152 Dave22152 marked this pull request as draft April 14, 2025 12:18
@Dave22152
Copy link
Contributor Author

Thanks @elstoc. I'll fix the link and the icons. How large would you suggest I make them?

@elstoc
Copy link
Contributor

elstoc commented Apr 14, 2025

I don't know, maybe twice the dimensions of the existing ones? Ideally if you could build the site locally, you could test. There's a sweet spot. Too large and when the website downsizes them the lines are thin and indistinct, too small and they look pixellated

@Dave22152
Copy link
Contributor Author

Dave22152 commented Apr 14, 2025

I corrected that link and enlarged the icons. I'm still working on converting my local repo to HTML, so hopefully this is an improvement

Update: I was able to build the site locally this morning and the changes look ok to me.

@github-actions
Copy link

This pull request has not had any activity in the past 60 days and will be closed in 365 days if not updated. Please verify it has no conflicts with the master branch and rebase if needed. Please add a comment if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No activity on this PR label Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-pr-activity No activity on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants