fix(plugins): Caddy config cache_keys json parse error

[dmagyari]

I'm not sure, how the cache_keys with regexp should exactly work by specification, but the following example in the Caddyfile did not work.

    cache {
        cache_keys {
            /.+ {
                headers Authorization
            }
        }
    }

The json parser of the CacheKeys struct shifted directives up and the regexp become the directive form inside the block.

[darkweak]

IMHO that's not an issue caused by the JSON parser.

[darkweak]

If you disable query within the cache_key then you can expect two stored responses because it should generate a key like that GET-http-localhost:9080-/query-string for both so the first one will receive a response that is stored and the second one will get a cached response.

[dmagyari]

Thanks for the quick reply.
If I run the new test case alone with go test -run TestCacheKeys, then it passes, but without the run filter the same test fails. Could be a persistent state between tests?

I expected the new test case to be valid because the query= regexp matches the first request and modifies the key generation to exclude the query string, and the key becomes GET-http-localhost:9080-/query-string. The second request does not match the regexp so the key generation should include the query string and the key becomes GET-http-localhost:9080-/query-string?foo=bar. Since it is a different key its a miss and store.
At least this was my understanding of the docs. What is the expected behavior in this case?

[dmagyari]

I changed the path in the test url to be unique among all tests, now running all tests passes.

[darkweak]

You were right I read to fast your PR, thank you 🙏. I still have a concern about the JSON parser.