fix(caddy): remove extra path in the admin caddy routes#632
Merged
Conversation
✅ Deploy Preview for teal-sprinkles-4c7f14 canceled.
|
2fca624 to
206f709
Compare
206f709 to
e334d4e
Compare
c4ad836 to
238ae6b
Compare
2025-05-30T17:05:56.158Z-iPad_Pro_landscape.jpeg |
mohammed90
reviewed
May 30, 2025
| return []caddy.AdminRoute{ | ||
| { | ||
| Pattern: basepath + "/{params...}", | ||
| Pattern: "/{params...}", |
Contributor
There was a problem hiding this comment.
This will likely cause issues with other modules that add to the admin API. It's not namespaced, so the souin API endpoint ends up being a catch-all for all requests. Running this config:
{
cache {
api {
debug
prometheus
souin
}
}
debug
}
localhost {
route {
cache
reverse_proxy localhost:8080
}
}
http://localhost:8080 {
respond "hi"
}I get this response for API requests unrelated to souin:
$ curl http://localhost:2019/test/
{"error":"resource not found: /test/"}
Which is coming from here:
Lines 47 to 51 in 516ed8c
Contributor
There was a problem hiding this comment.
@darkweak, I think this is critical because it may be an unintended side-effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #631