Fix storeTag regex performance bottleneck#697
Merged
darkweak merged 1 commit intodarkweak:masterfrom Feb 12, 2026
Merged
Conversation
✅ Deploy Preview for teal-sprinkles-4c7f14 canceled.
|
b2974ab to
69160ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #696
Warning: This was entirely done by Claude Code
Problem
The
storeTagfunction was using regex matching to check for duplicate cache keys in the stored comma-separated list. This caused ~57% CPU consumption because:Store()callSolution
Replace regex matching with simple string operations (
strings.HasPrefix,strings.HasSuffix,strings.Contains) that provide O(n) complexity and leverage Go's optimizedstringspackage.Changes
containsCacheKey()helper function using fast string operationsstoreTag()regexp.MustCompile()calls fromStore()SurrogateInterfaceto reflect new signaturecontainsCacheKey()covering edge cases