Draft
Conversation
jlucfarias
suggested changes
Nov 1, 2025
Contributor
jlucfarias
left a comment
jlucfarias
left a comment
There was a problem hiding this comment.
Some changes needed. I don't think most of these values have changed for newer versions but review based on 10.13 MacOS
Comment on lines
+26
to
+39
| const CFStringRef kCMFormatDescriptionColorPrimaries_ITU_R_2020 = CFSTR("CMFormatDescriptionColorPrimaries_ITU_R_2020"); | ||
| const CFStringRef kCMFormatDescriptionColorPrimaries_DCI_P3 = CFSTR("CMFormatDescriptionColorPrimaries_DCI_P3"); | ||
| const CFStringRef kCMFormatDescriptionColorPrimaries_P3_D65 = CFSTR("CMFormatDescriptionColorPrimaries_P3_D65"); | ||
| const CFStringRef kCMFormatDescriptionExtension_ContentLightLevelInfo = CFSTR("CMFormatDescriptionExtension_ContentLightLevelInfo"); | ||
| const CFStringRef kCMFormatDescriptionExtension_Depth = CFSTR("CMFormatDescriptionExtension_Depth"); | ||
| const CFStringRef kCMFormatDescriptionExtension_FormatName = CFSTR("CMFormatDescriptionExtension_FormatName"); | ||
| const CFStringRef kCMFormatDescriptionExtension_FullRangeVideo = CFSTR("CMFormatDescriptionExtension_FullRangeVideo"); | ||
| const CFStringRef kCMFormatDescriptionExtension_SampleDescriptionExtensionAtoms = CFSTR("SampleDescriptionExtensionAtoms"); | ||
| const CFStringRef kCMFormatDescriptionExtension_MasteringDisplayColorVolume = CFSTR("CMFormatDescriptionExtension_MasteringDisplayColorVolume"); | ||
| const CFStringRef kCMFormatDescriptionTransferFunction_ITU_R_2020 = CFSTR("CMFormatDescriptionTransferFunction_ITU_R_2020"); | ||
| const CFStringRef kCMFormatDescriptionTransferFunction_ITU_R_2100_HLG = CFSTR("CMFormatDescriptionTransferFunction_ITU_R_2100_HLG"); | ||
| const CFStringRef kCMFormatDescriptionTransferFunction_SMPTE_ST_2084_PQ = CFSTR("CMFormatDescriptionTransferFunction_SMPTE_ST_2084_PQ"); | ||
| const CFStringRef kCMFormatDescriptionTransferFunction_SMPTE_ST_428_1 = CFSTR("CMFormatDescriptionTransferFunction_SMPTE_ST_428_1"); | ||
| const CFStringRef kCMFormatDescriptionYCbCrMatrix_ITU_R_2020 = CFSTR("CMFormatDescriptionYCbCrMatrix_ITU_R_2020"); |
Contributor
There was a problem hiding this comment.
Suggested change
| const CFStringRef kCMFormatDescriptionColorPrimaries_ITU_R_2020 = CFSTR("CMFormatDescriptionColorPrimaries_ITU_R_2020"); | |
| const CFStringRef kCMFormatDescriptionColorPrimaries_DCI_P3 = CFSTR("CMFormatDescriptionColorPrimaries_DCI_P3"); | |
| const CFStringRef kCMFormatDescriptionColorPrimaries_P3_D65 = CFSTR("CMFormatDescriptionColorPrimaries_P3_D65"); | |
| const CFStringRef kCMFormatDescriptionExtension_ContentLightLevelInfo = CFSTR("CMFormatDescriptionExtension_ContentLightLevelInfo"); | |
| const CFStringRef kCMFormatDescriptionExtension_Depth = CFSTR("CMFormatDescriptionExtension_Depth"); | |
| const CFStringRef kCMFormatDescriptionExtension_FormatName = CFSTR("CMFormatDescriptionExtension_FormatName"); | |
| const CFStringRef kCMFormatDescriptionExtension_FullRangeVideo = CFSTR("CMFormatDescriptionExtension_FullRangeVideo"); | |
| const CFStringRef kCMFormatDescriptionExtension_SampleDescriptionExtensionAtoms = CFSTR("SampleDescriptionExtensionAtoms"); | |
| const CFStringRef kCMFormatDescriptionExtension_MasteringDisplayColorVolume = CFSTR("CMFormatDescriptionExtension_MasteringDisplayColorVolume"); | |
| const CFStringRef kCMFormatDescriptionTransferFunction_ITU_R_2020 = CFSTR("CMFormatDescriptionTransferFunction_ITU_R_2020"); | |
| const CFStringRef kCMFormatDescriptionTransferFunction_ITU_R_2100_HLG = CFSTR("CMFormatDescriptionTransferFunction_ITU_R_2100_HLG"); | |
| const CFStringRef kCMFormatDescriptionTransferFunction_SMPTE_ST_2084_PQ = CFSTR("CMFormatDescriptionTransferFunction_SMPTE_ST_2084_PQ"); | |
| const CFStringRef kCMFormatDescriptionTransferFunction_SMPTE_ST_428_1 = CFSTR("CMFormatDescriptionTransferFunction_SMPTE_ST_428_1"); | |
| const CFStringRef kCMFormatDescriptionYCbCrMatrix_ITU_R_2020 = CFSTR("CMFormatDescriptionYCbCrMatrix_ITU_R_2020"); | |
| const CFStringRef kCMFormatDescriptionColorPrimaries_ITU_R_2020 = CFSTR("ITU_R_2020"); | |
| const CFStringRef kCMFormatDescriptionColorPrimaries_DCI_P3 = CFSTR("DCI_P3"); | |
| const CFStringRef kCMFormatDescriptionColorPrimaries_P3_D65 = CFSTR("P3_D65"); | |
| const CFStringRef kCMFormatDescriptionExtension_ContentLightLevelInfo = CFSTR("ContentLightLevelInfo"); | |
| const CFStringRef kCMFormatDescriptionExtension_Depth = CFSTR("Depth"); | |
| const CFStringRef kCMFormatDescriptionExtension_FormatName = CFSTR("FormatName"); | |
| const CFStringRef kCMFormatDescriptionExtension_FullRangeVideo = CFSTR("FullRangeVideo"); | |
| const CFStringRef kCMFormatDescriptionExtension_SampleDescriptionExtensionAtoms = CFSTR("SampleDescriptionExtensionAtoms"); | |
| const CFStringRef kCMFormatDescriptionExtension_MasteringDisplayColorVolume = CFSTR("MasteringDisplayColorVolume"); | |
| const CFStringRef kCMFormatDescriptionTransferFunction_ITU_R_2020 = CFSTR("ITU_R_2020"); | |
| const CFStringRef kCMFormatDescriptionTransferFunction_ITU_R_2100_HLG = CFSTR("ITU_R_2100_HLG"); | |
| const CFStringRef kCMFormatDescriptionTransferFunction_SMPTE_ST_2084_PQ = CFSTR("SMPTE_ST_2084_PQ"); | |
| const CFStringRef kCMFormatDescriptionTransferFunction_SMPTE_ST_428_1 = CFSTR("SMPTE_ST_428_1"); | |
| const CFStringRef kCMFormatDescriptionYCbCrMatrix_ITU_R_2020 = CFSTR("ITU_R_2020"); |
| const CFStringRef kVTDecompressionPropertyKey_UsingHardwareAcceleratedVideoDecoder = CFSTR("UsingHardwareAcceleratedVideoDecoder"); | ||
| const CFStringRef kVTEncodeFrameOptionKey_ForceKeyFrame = CFSTR("ForceKeyFrame"); | ||
| const CFStringRef kVTProfileLevel_H264_Baseline_AutoLevel = CFSTR("AutoLevel"); | ||
| const CFStringRef kVTProfileLevel_H264_High_AutoLevel = CFSTR("AutoLevel"); |
Contributor
There was a problem hiding this comment.
Suggested change
| const CFStringRef kVTProfileLevel_H264_High_AutoLevel = CFSTR("AutoLevel"); | |
| const CFStringRef kVTProfileLevel_H264_High_AutoLevel = CFSTR("H264_High_AutoLevel"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same description as darlinghq/darling-cocotron#52