Skip to content

Update mirai::daemons() arguments #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daroczig merged 1 commit into from
Jan 9, 2025
Merged

Update mirai::daemons() arguments #219

daroczig merged 1 commit into from
Jan 9, 2025

Conversation

@shikokuchuo
Copy link
Contributor

@shikokuchuo shikokuchuo commented Jan 9, 2025

Really minimal changes:

  • dispatcher argument reverts to a logical value post mirai v2 (also accepted previously)
  • set cleanup to FALSE for more efficiency as there is no need to reset after each evaluation

No urgency in applying these as the current values will continue to be supported for a while.

@daroczig
Copy link
Owner

daroczig commented Jan 9, 2025

Fantastic, thank you very much 🙇

@daroczig daroczig merged commit 434bfa0 into daroczig:main Jan 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daroczig daroczig daroczig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shikokuchuo @daroczig