Store item context in player queue playlist

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,34 @@
+---
+name: Bug report
+about: Report a bug report to improve the quality of LMS.
+title: ''
+labels: bug
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is. If you're unsure about the nature of your request, please use [forums.lyrion.org](https://forums.lyrion.org) instead. You'll get better and faster responses there. Thanks!
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**System Information (please complete the following information):**
+ - OS on which you're running LMS: [e.g. pCP 10]
+ - Web skin used: [e.g. Material, Default]
+ - Browser [e.g. chrome, safari]
+ - LMS Version [e.g. 22]
+ - Player(s) involved
+
+**Additional context**
+Add any other context about the problem here. E.g. a `server.log` or `scanner.log` snippet (see Settings/Information in your LMS)

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,5 @@
+blank_issues_enabled: true
+contact_links:
+  - name: Lyrion Community Forum
+    url: https://forums.lyrion.org
+    about: 👉🏼 Please ask and answer questions here. You'll get faster and better help.

.github/actions/build/action.yaml

@@ -22,9 +22,9 @@ runs:
       id: getversion
       run: |
         echo "::group::Get LMS version number"
-        MAJOR=$(grep "\$VERSION" server/slimserver.pl | head -n1 | cut -d"'" -f2 | cut -d. -f1)
-        MINOR=$(grep "\$VERSION" server/slimserver.pl | head -n1 | cut -d"'" -f2 | cut -d. -f2)
-        PATCH=$(grep "\$VERSION" server/slimserver.pl | head -n1 | cut -d"'" -f2 | cut -d. -f3)
+        MAJOR=$(grep "our \$VERSION" -m1 server/slimserver.pl | cut -d"'" -f2 | cut -d. -f1)
+        MINOR=$(grep "our \$VERSION" -m1 server/slimserver.pl | cut -d"'" -f2 | cut -d. -f2)
+        PATCH=$(grep "our \$VERSION" -m1 server/slimserver.pl | cut -d"'" -f2 | cut -d. -f3)
 
         echo "LMS_VERSION=$MAJOR.$MINOR" >> $GITHUB_OUTPUT
         echo "LMS_FULL_VERSION=$MAJOR.$MINOR.$PATCH" >> $GITHUB_OUTPUT
@@ -40,6 +40,14 @@ runs:
         ref: ${{ steps.getversion.outputs.GIT_BRANCH }}
 
 
+    - name: Check out pCP platform code
+      if: ${{ startsWith(inputs.build-params, 'pcp') }}
+      uses: actions/checkout@v4
+      with:
+        repository: picoreplayer/lms-update-script
+        path: platforms/pcp
+
+
     - name: Set up Docker environment
       if: ${{ startsWith(inputs.build-params, 'docker') }}
       id: dockersetup
@@ -49,9 +57,9 @@ runs:
         if [ "${{ inputs.build-type }}" = "release" ]; then
           echo "LMS_TAG=--tag=rc" >> $GITHUB_OUTPUT
         elif [ "${{ steps.getversion.outputs.LMS_VERSION }}" = "9.1" ]; then
-          echo "LMS_TAG=--tag=dev" >> $GITHUB_OUTPUT
+          echo "LMS_TAG=--tag=dev,${{ steps.getversion.outputs.LMS_FULL_VERSION }}-dev" >> $GITHUB_OUTPUT
         elif [ "${{ steps.getversion.outputs.LMS_VERSION }}" = "9.0" ]; then
-          echo "LMS_TAG=--tag=stable" >> $GITHUB_OUTPUT
+          echo "LMS_TAG=--tag=stable,${{ steps.getversion.outputs.LMS_FULL_VERSION }}-stable" >> $GITHUB_OUTPUT
         else
           echo "UNKNOWN DOCKER TARGET TAG"
           exit 1
@@ -114,6 +122,8 @@ runs:
 
     - name: Set-up s5cmd
       if: ${{ !startsWith(inputs.build-params, 'docker') }}
+      # don't fail, as we can fall back to aws-cli
+      continue-on-error: true
       uses: ./server/.github/actions/setup-s5cmd
       # uses: peak/action-setup-s5cmd@main
       with:

.github/workflows/00_build.yaml

@@ -22,7 +22,7 @@ on:
 
 jobs:
   mac:
-    name: Build LMS for Mac (MenuBar Item)
+    name: Build LMS for Mac
     runs-on: macos-13
     env:
       BUILD_CERTIFICATE_BASE64: ${{ secrets.BUILD_CERTIFICATE_BASE64 }}
@@ -85,6 +85,7 @@ jobs:
           - [tarball, ""]
           - [tarball, "--encore"]
           - [tarball, "--noCPAN"]
+          - [pcp, ""]
 
     steps:
       # we must check out here, as  otherwise the build action is not available
@@ -95,10 +96,10 @@ jobs:
           ref: ${{ inputs.branch }}
 
       - name: Prepare build environment
-        if: ${{ matrix.flavour[0] != 'tarball' }}
+        if: ${{ matrix.flavour[0] != 'tarball' && matrix.flavour[0] != 'pcp' }}
         run: |
           sudo apt update
-          sudo apt install apt-transport-https debhelper devscripts
+          sudo apt install -y apt-transport-https debhelper devscripts
 
       - name: Launch build process
         uses: ./server/.github/actions/build
@@ -169,3 +170,28 @@ jobs:
       - env:
           GH_TOKEN: ${{ secrets.DEPLOYMENT_KEY }}
         run: gh workflow run update-server-repository.yml -R https://github.com/LMS-Community/lms-server-repository
+
+  tagRelease:
+    name: Tag the current release
+    if: ${{ success() && inputs.build_type == 'release' && github.repository_owner == 'LMS-Community' }}
+    runs-on: ubuntu-latest
+    needs:
+      - updateRepoFile
+    permissions:
+      actions: write
+      contents: write
+    steps:
+      # no easy way to avoid another checkout?
+      - name: Check out LMS code
+        uses: actions/checkout@v4
+        with:
+          path: server
+          ref: ${{ inputs.branch }}
+      - name: Tag that thang
+        run: |
+          cd server
+          VERSION=$(grep "our \$VERSION" -m1 slimserver.pl | cut -d"'" -f2)
+          git config user.name "LMS Server Repository Updater"
+          git config user.email "[email protected]"
+          git tag -a -m -f "$VERSION"
+          git push origin refs/tags/$VERSION

.github/workflows/00_cron.yaml

@@ -2,7 +2,7 @@ name: Build LMS Scheduler
 on:
   workflow_dispatch:
   schedule:
-    - cron:  '40 2 * * *'
+    - cron:  '40 2,3,4 * * *'
 
 jobs:
   check:
@@ -13,18 +13,23 @@ jobs:
       - uses: actions/github-script@v7
         with:
           script: |
-            const repoStatus = await github.request('GET https://lms-community.github.io/lms-server-repository/servers.json');
+            const repoStatus = await github.request('GET https://raw.githubusercontent.com/LMS-Community/lms-server-repository/refs/heads/master/servers.json');
 
             if (repoStatus.status !== 200) {
+              console.error("Fetching repo file failed?" + JSON.stringify(repoStatus, null, 2));
               return false;
             }
 
             // get the oldest timestamp for each version from previous builds
             const candidates = [];
-            Object.keys(repoStatus.data).forEach(version => {
+            const repoData = JSON.parse(repoStatus.data);
+
+            Object.keys(repoData).sort((a, b) => {
+              return 0.5 - Math.random();
+            }).forEach(version => {
               const matches = version.match(/(\d+\.\d+)\.\d+/);
               if (matches && matches.length == 2) {
-                const versionBuilds = repoStatus.data[version];
+                const versionBuilds = repoData[version];
                 candidates.push({
                   v: matches[1],
                   r: Object.keys(versionBuilds).reduce((accumulator, build) => {
@@ -35,16 +40,11 @@ jobs:
                 })
               }
               else {
-                delete repoStatus.data[version];
+                delete repoData[version];
               }
             });
 
-            const sleep = (s) => {
-                return new Promise(resolve => setTimeout(resolve, s * 1000));
-            }
-
             // for each version see whether there's a more recent commit than the revision of the previous build
-            let buildsRunning = 0;
             for (let i = 0; i < candidates.length; i++) {
               const latestBuildTimestamp = candidates[i].r * 1000;
 
@@ -68,24 +68,23 @@ jobs:
               if (needsBuild) {
                 console.log(`${candidates[i].v}: needs a build (${new Date(needsBuild.commit.committer.date).getTime()} > ${latestBuildTimestamp})`);
 
-                if (buildsRunning > 0) {
-                  console.log('Delaying build as there is already a build running');
-                  // wait about Xs per build
-                  await sleep(buildsRunning * 90);
-                }
-
                 const workflowStatus = await github.rest.actions.createWorkflowDispatch({
                   owner: context.repo.owner,
                   repo: context.repo.repo,
                   workflow_id: '00_build.yaml',
                   ref: 'public/' + candidates[i].v,
+                  inputs: {
+                    branch: 'public/' + candidates[i].v,
+                    build_type: 'nightly',
+                  },
                 });
 
                 if (workflowStatus.status < 200 || workflowStatus.status > 204) {
                   console.log(workflowStatus);
                 }
 
-                buildsRunning++;
+                // we only want to run one build at a time - we'll re run the check in a bit
+                break;
               }
               else {
                 console.log(`${candidates[i].v}: is up to date (${candidates[i].r})`);

CPAN/Protocol/WebSocket.pm

@@ -0,0 +1,158 @@
+package Protocol::WebSocket;
+
+use strict;
+use warnings;
+
+our $VERSION = '0.26';
+
+use Protocol::WebSocket::Frame;
+use Protocol::WebSocket::Handshake::Client;
+use Protocol::WebSocket::Handshake::Server;
+use Protocol::WebSocket::URL;
+
+1;
+__END__
+
+=encoding UTF-8
+
+=head1 NAME
+
+Protocol::WebSocket - WebSocket protocol
+
+=head1 SYNOPSIS
+
+    # Server side
+    my $hs = Protocol::WebSocket::Handshake::Server->new;
+
+    $hs->parse('some data from the client');
+
+    $hs->is_done; # tells us when handshake is done
+
+    my $frame = $hs->build_frame;
+
+    $frame->append('some data from the client');
+
+    while (defined(my $message = $frame->next)) {
+        if ($frame->is_close) {
+
+            # Send close frame back
+            send(
+                $hs->build_frame(
+                    type    => 'close',
+                    version => $version
+                )->to_bytes
+            );
+
+            return;
+        }
+
+        # We got a message!
+    }
+
+=head1 DESCRIPTION
+
+Client/server WebSocket message and frame parser/constructor. This module does
+not provide a WebSocket server or client, but is made for using in http servers
+or clients to provide WebSocket support.
+
+L<Protocol::WebSocket> supports the following WebSocket protocol versions:
+
+    draft-ietf-hybi-17 (latest)
+    draft-ietf-hybi-10
+    draft-ietf-hybi-00 (with HAProxy support)
+    draft-hixie-75
+
+By default the latest version is used. The WebSocket version is detected
+automatically on the server side. On the client side you have set a C<version>
+attribute to an appropriate value.
+
+L<Protocol::WebSocket> itself does not contain any code and cannot be used
+directly. Instead the following modules should be used:
+
+=head2 High-level modules
+
+=head3 L<Protocol::WebSocket::Server>
+
+Server helper class.
+
+=head3 L<Protocol::WebSocket::Client>
+
+Client helper class.
+
+=head2 Low-level modules
+
+=head3 L<Protocol::WebSocket::Handshake::Server>
+
+Server handshake parser and constructor.
+
+=head3 L<Protocol::WebSocket::Handshake::Client>
+
+Client handshake parser and constructor.
+
+=head3 L<Protocol::WebSocket::Frame>
+
+WebSocket frame parser and constructor.
+
+=head3 L<Protocol::WebSocket::Request>
+
+Low level WebSocket request parser and constructor.
+
+=head3 L<Protocol::WebSocket::Response>
+
+Low level WebSocket response parser and constructor.
+
+=head3 L<Protocol::WebSocket::URL>
+
+Low level WebSocket url parser and constructor.
+
+=head1 EXAMPLES
+
+For examples on how to use L<Protocol::WebSocket> with various event loops see
+C<examples/> directory in the distribution.
+
+=head1 CREDITS
+
+In order of appearance:
+
+Paul "LeoNerd" Evans
+
+Jon Gentle
+
+Lee Aylward
+
+Chia-liang Kao
+
+Atomer Ju
+
+Chuck Bredestege
+
+Matthew Lien (BlueT)
+
+Joao Orui
+
+Toshio Ito (debug-ito)
+
+Neil Bowers
+
+Michal Špaček
+
+Graham Ollis
+
+Anton Petrusevich
+
+Eric Wastl
+
+Greg Kennedy
+
+=head1 AUTHOR
+
+Viacheslav Tykhanovskyi, C<[email protected]>.
+
+=head1 COPYRIGHT
+
+Copyright (C) 2010-2018, Viacheslav Tykhanovskyi.
+
+This program is free software, you can redistribute it and/or modify it under
+the same terms as Perl 5.10.
+
+=cut