Update textual-dev, .gitignore .lock file, update pyproject.toml to latest poetry conventions#4
Open
ssteinerx wants to merge 3 commits intodarrenburns:mainfrom
Open
Update textual-dev, .gitignore .lock file, update pyproject.toml to latest poetry conventions#4ssteinerx wants to merge 3 commits intodarrenburns:mainfrom
ssteinerx wants to merge 3 commits intodarrenburns:mainfrom
Conversation
The former textual = "^0.37.1" spec, was keeping textual back at 0.37.?? even though textual-dev is good to 0.60.xxx. FIX: Only specify textual-dev, remove explicit textual version spec. Now, textual-dev is updated, it will pull textual along with it to the latest compatible version. Look Ma, no hands! Per Poetry doc: "An update is allowed if the new version number does not modify the left-most non-zero digit in the major, minor, patch grouping."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specified
textualdependency was keeping textual waaaaaay back. I changed the dependency to be ontextual-dev, which will pulltextualalong with it sotextualdoesn't get stuck. Sincetextual's versions are0.xx.0, once you pick anxxit will never update due to the way Poetry handles semver.Added
poetry.lockto .gitignore. In my experience, during development (e.g. before 1.0), it just holds things back unnecessarily and leads to dependencies on out of date libraries. Once you hit 1.0, sure, to make sure people are running the right mix, but before that it just makes for confusing conflicts with no real benefit and nasty surprises when people eventually install "the latest" version of something and breaks the world. I'd rather have that happen during development.I also added
ruffsince I prefer it for formatting. It's a dev only dependency, so it won't fatten any distribution.Also, moved the dev dependencies to Poetry's new location of
[tool.poetry.group.dev.dependencies]wherepoetry install --group dev, the "new, improved" way of specifying dev dependencies will put it.