MAINT: invalid log detection #776
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* related to darshan-hpcgh-564 * add a default-off keyword to `DarshanReport()` that can detect some obviously-invalid log properties, for now restricted to invalid time values that are `< -1`. * add a regression test for this new machinery, with the known case described in darshan-hpcgh-562 * I think the plan is to eventually turn this testing on for all logs added to the logs repo, though I have not done that just yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to Pydarshan bad log detection/rejection #564
add a default-off keyword to
DarshanReport()that candetect some obviously-invalid log properties, for now
restricted to invalid time values that are
< -1.add a regression test for this new machinery, with
the known case described in Decide how to handle bad logs (
sample.darshan) #562I think the plan is to eventually turn this testing on
for all logs added to the logs repo, though I have
not done that just yet