TST: add Python-level filter test #901
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a regression test comparing the manual Perl-based single-file filtering prior to accumulator API usage vs. the current Python "API" equivalent * we'll probably want documentation demonstrating this as well, but the regression test is probably higher priority in the short term * note also that we would currently place the burden of expanding the dataframes to include the file paths/names proper up to the end user (currently only have columns with the `id`/hash) if they wanted to filter by regex; that said, we do have library functions that do this kind of thing internally anyway... all of this is to say that just writing this test will probably expose some design thinking, or at least reveal some of the more complex things we may want in our docs for filtering in Python route * finally, note that Phil C. did forward a C program and some other assets for developing a test like this; however, it is far easier for me to just perform the steps manually on log files that are already in the logs repo (that was kind of what I was hoping for--expected values for counters/derived metrics given a log file and a single file hash, but I've just gone ahead and pulled them out myself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a regression test comparing the manual Perl-based single-file filtering prior to accumulator API usage vs. the current Python "API" equivalent
we'll probably want documentation demonstrating this as well, but the regression test is probably higher priority in the short term
note also that we would currently place the burden of expanding the dataframes to include the file paths/names proper up to the end user (currently only have columns with the
id/hash) if they wanted to filter by regex; that said, we do have library functions that do this kind of thing internally anyway... all of this is to say that just writing this test will probably expose some design thinking, or at least reveal some of the more complex things we may want in our docs for filtering in Python routefinally, note that Phil C. did forward a C program and some other assets for developing a test like this; however, it is far easier for me to just perform the steps manually on log files that are already in the logs repo (that was kind of what I was hoping for--expected values for counters/derived metrics given a log file and a single file hash, but I've just gone ahead and pulled them out myself)