-
Couldn't load subscription status.
- Fork 36
WIP, ENH: parquet demo #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tylerjereddy
wants to merge
2
commits into
darshan-hpc:main
Choose a base branch
from
tylerjereddy:treddy_parquet_demo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,6 +17,8 @@ | |||||
| import os | ||||||
| import glob | ||||||
| from typing import Optional, Any | ||||||
| import darshan | ||||||
| import pandas as pd | ||||||
|
|
||||||
| if "pytest" in sys.modules: | ||||||
| # only import pytest if used in a testing context | ||||||
|
|
@@ -102,3 +104,20 @@ def get_log_path(filename: str) -> str: | |||||
| pytest.skip(err_msg) | ||||||
| else: | ||||||
| raise FileNotFoundError(err_msg) | ||||||
|
|
||||||
|
|
||||||
| def convert_to_parquet(darshan_log_filename: str, | ||||||
| out_filepath: str): | ||||||
| # NOTE: only supports POSIX, and only tested on | ||||||
| # 1 log file so far... | ||||||
| with darshan.DarshanReport(darshan_log_filename) as report: | ||||||
| recs = report.data["records"] | ||||||
| df_posix_counters = recs["POSIX"].to_df()["counters"] | ||||||
| df_posix_fcounters = recs["POSIX"].to_df()["fcounters"] | ||||||
| # NOTE: is it always true that counters and counters will | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| # have the same number of records for a given darshan log? | ||||||
| assert df_posix_counters.shape[0] == df_posix_fcounters.shape[0] | ||||||
| df_fused = pd.concat([df_posix_counters, df_posix_fcounters.iloc[..., 2:]], | ||||||
| axis=1) | ||||||
| df_fused.to_parquet(out_filepath, | ||||||
| compression="gzip") | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the one table I added support for in the parquet-based summary report, since it was so easy. You just take the dataframe you loaded in from the parquet file, and slice it to get the counters sub-portion of the fused counters + fcounters DataFrame.
How we store metadata (job runtime and stuff...), and avoid having to hard-code magic numbers like that for the number of columns for different modules/counters is probably a design question.