fix(shadow_dom_emulation): fix content reprojection bug.

rkirov · rkirov · commit 0db910aee9a7 · 2015-04-24T16:35:41.000-07:00
On non-shadow DOM enabled browsers content tag cannot be checked by
using the type of the element. Instead the tagName should be used.
diff --git a/lib/core_dom/light_dom.dart b/lib/core_dom/light_dom.dart
@@ -87,7 +87,7 @@ class LightDom implements SourceLightDom, DestinationLightDom {
     for(final root in _lightDomRootNodes) {
       if (_ports.containsKey(root)) {
         list.addAll(_ports[root].nodes);
-      } else if (root is dom.ContentElement) {
+      } else if (isContentElement(root)) {
         if (!_contentTags.containsKey(root))
           throw new Exception('Unmatched content tag encountered during redistibution.');
         list.addAll(_contentTags[root].nodes);
@@ -97,6 +97,8 @@ class LightDom implements SourceLightDom, DestinationLightDom {
     }
     return list;
   }
+
+  static isContentElement(dom.Node node) => node is dom.Element && node.tagName == 'CONTENT';
 }
 
 void redistributeNodes(Iterable<Content> contents, List<dom.Node> nodes) {

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ class LightDom implements SourceLightDom, DestinationLightDom {`
`87`	`87`	`for(final root in _lightDomRootNodes) {`
`88`	`88`	`if (_ports.containsKey(root)) {`
`89`	`89`	`list.addAll(_ports[root].nodes);`
`90`		`- } else if (root is dom.ContentElement) {`
	`90`	`+ } else if (isContentElement(root)) {`
`91`	`91`	`if (!_contentTags.containsKey(root))`
`92`	`92`	`throw new Exception('Unmatched content tag encountered during redistibution.');`
`93`	`93`	`list.addAll(_contentTags[root].nodes);`
`@@ -97,6 +97,8 @@ class LightDom implements SourceLightDom, DestinationLightDom {`
`97`	`97`	`}`
`98`	`98`	`return list;`
`99`	`99`	`}`
	`100`	`+`
	`101`	`+ static isContentElement(dom.Node node) => node is dom.Element && node.tagName == 'CONTENT';`
`100`	`102`	`}`
`101`	`103`
`102`	`104`	`void redistributeNodes(Iterable<Content> contents, List<dom.Node> nodes) {`