test(vscode): use stub.resolves over stub.returns with Promise (#862)

Author: alestiago

extensions/vscode/src/test/suite/commands/create.test.ts

@@ -45,7 +45,7 @@ suite("create command", () => {
 
   suite("file open dialog", () => {
     test("is shown when Uri is undefined", async () => {
-      vscodeStub.window.showOpenDialog.returns(Promise.resolve(undefined));
+      vscodeStub.window.showOpenDialog.resolves();
 
       await command.create();
 
@@ -164,7 +164,7 @@ suite("create command", () => {
   });
 
   test("runs `dart_frog create` command when project name is valid and uri not defined", async () => {
-    vscodeStub.window.showOpenDialog.returns(Promise.resolve([targetUri]));
+    vscodeStub.window.showOpenDialog.resolves([targetUri]);
     vscodeStub.window.showInputBox.returns("my_project");
 
     await command.create();

extensions/vscode/src/test/suite/commands/new-middleware.test.ts

@@ -53,7 +53,7 @@ suite("new-middleware command", () => {
 
   suite("file open dialog", () => {
     test("is shown when Uri is undefined and fails to resolve a path from workspace", async () => {
-      vscodeStub.window.showOpenDialog.returns(Promise.resolve(undefined));
+      vscodeStub.window.showOpenDialog.resolves();
       utilsStub.resolveDartFrogProjectPathFromWorkspace.returns(undefined);
 
       await command.newMiddleware();
@@ -89,15 +89,15 @@ suite("new-middleware command", () => {
     const errorMessage = "Please select a valid directory";
 
     test("is shown when Uri is undefined and selected file is undefined", async () => {
-      vscodeStub.window.showOpenDialog.returns(Promise.resolve(undefined));
+      vscodeStub.window.showOpenDialog.resolves();
 
       await command.newMiddleware();
 
       sinon.assert.calledWith(vscodeStub.window.showErrorMessage, errorMessage);
     });
 
     test("is not shown when Uri is undefined and selected file is given", async () => {
-      vscodeStub.window.showOpenDialog.returns(Promise.resolve([invalidUri]));
+      vscodeStub.window.showOpenDialog.resolves([invalidUri]);
 
       await command.newMiddleware();
 
@@ -115,7 +115,7 @@ suite("new-middleware command", () => {
         "No Dart Frog project found in the selected directory";
 
       test("is shown when Uri is undefined and selected file is invalid", async () => {
-        vscodeStub.window.showOpenDialog.returns(Promise.resolve([invalidUri]));
+        vscodeStub.window.showOpenDialog.resolves([invalidUri]);
 
         await command.newMiddleware();
 

extensions/vscode/src/test/suite/commands/new-route.test.ts

@@ -126,7 +126,7 @@ suite("new-route command", () => {
   suite("file open dialog", () => {
     test("is shown when Uri is undefined and fails to resolve a path from workspace", async () => {
       vscodeStub.window.showInputBox.returns(validRouteName);
-      vscodeStub.window.showOpenDialog.returns(Promise.resolve(undefined));
+      vscodeStub.window.showOpenDialog.resolves();
       utilsStub.resolveDartFrogProjectPathFromWorkspace.returns(undefined);
 
       await command.newRoute();
@@ -164,7 +164,7 @@ suite("new-route command", () => {
 
     test("is shown when Uri is undefined and selected file is undefined", async () => {
       vscodeStub.window.showInputBox.returns(validRouteName);
-      vscodeStub.window.showOpenDialog.returns(Promise.resolve(undefined));
+      vscodeStub.window.showOpenDialog.resolves();
 
       await command.newRoute();
 
@@ -173,7 +173,7 @@ suite("new-route command", () => {
 
     test("is not shown when Uri is undefined and selected file is given", async () => {
       vscodeStub.window.showInputBox.returns(validRouteName);
-      vscodeStub.window.showOpenDialog.returns(Promise.resolve([invalidUri]));
+      vscodeStub.window.showOpenDialog.resolves([invalidUri]);
 
       await command.newRoute();
 
@@ -192,7 +192,7 @@ suite("new-route command", () => {
 
       test("is shown when Uri is undefined and selected file is invalid", async () => {
         vscodeStub.window.showInputBox.returns(validRouteName);
-        vscodeStub.window.showOpenDialog.returns(Promise.resolve([invalidUri]));
+        vscodeStub.window.showOpenDialog.resolves([invalidUri]);
 
         await command.newRoute();