Renamed enum values to be lower-case

Closes #94

Author: kevmoo

.analysis_options

@@ -8,7 +8,7 @@ linter:
     - avoid_init_to_null
     - avoid_return_types_on_setters
     - camel_case_types
-    # - constant_identifier_names # https://github.com/dart-lang/build/issues/94
+    - constant_identifier_names
     - empty_constructor_bodies
     - hash_and_equals
     - library_names

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.3.0
+- **BREAKING** Renamed values of three enums to be lower-case:
+  `BuildType`, `BuildStatus`, and `PackageDependencyType`.
+
 ## 0.2.1
 - Added the `deleteFilesByDefault` option to all top level methods. This will
   skip the prompt to delete files, and instead act as if you responded `y`.

lib/src/generate/build_impl.dart

@@ -60,7 +60,7 @@ class BuildImpl {
   ///
   /// The returned [Future] is guaranteed to complete with a [BuildResult]. If
   /// an exception is thrown by any phase, [BuildResult#status] will be set to
-  /// [BuildStatus.Failure]. The exception and stack trace that caused the failure
+  /// [BuildStatus.failure]. The exception and stack trace that caused the failure
   /// will be available as [BuildResult#exception] and [BuildResult#stackTrace]
   /// respectively.
   ///
@@ -74,7 +74,7 @@ class BuildImpl {
     var watch = new Stopwatch()..start();
 
     /// Assume incremental, change if necessary.
-    var buildType = BuildType.Incremental;
+    var buildType = BuildType.incremental;
     var done = new Completer<BuildResult>();
     Chain.capture(() async {
       if (_buildRunning) throw const ConcurrentBuildException();
@@ -88,7 +88,7 @@ class BuildImpl {
           if (_assetGraph.allNodes.isEmpty &&
               !(await _reader.hasInput(_assetGraphId))) {
             isNewAssetGraph = true;
-            buildType = BuildType.Full;
+            buildType = BuildType.full;
           } else {
             /// Collect updates since the asset graph was last created. This only
             /// handles updates and deletes, not adds. We list the file system for
@@ -109,7 +109,7 @@ class BuildImpl {
         await logWithTime(_logger, 'Checking build script for updates',
             () async {
           if (await _buildScriptUpdated()) {
-            buildType = BuildType.Full;
+            buildType = BuildType.full;
             if (_isFirstBuild) {
               _logger.warning(
                   'Invalidating asset graph due to build script update');
@@ -118,7 +118,7 @@ class BuildImpl {
                   .forEach((node) =>
                       (node as GeneratedAssetNode).needsUpdate = true);
             } else {
-              done.complete(new BuildResult(BuildStatus.Failure, buildType, [],
+              done.complete(new BuildResult(BuildStatus.failure, buildType, [],
                   exception: new BuildScriptUpdatedException()));
             }
           }
@@ -157,13 +157,13 @@ class BuildImpl {
 
       done.complete(result);
     }, onError: (e, Chain chain) {
-      done.complete(new BuildResult(BuildStatus.Failure, buildType, [],
+      done.complete(new BuildResult(BuildStatus.failure, buildType, [],
           exception: e, stackTrace: chain.toTrace()));
     });
     var result = await done.future;
     _buildRunning = false;
     _isFirstBuild = false;
-    if (result.status == BuildStatus.Success) {
+    if (result.status == BuildStatus.success) {
       _logger.info('Succeeded after ${watch.elapsedMilliseconds}ms with '
           '${result.outputs.length} outputs\n\n');
     } else {
@@ -455,7 +455,7 @@ class BuildImpl {
         _inputsByPackage[outputId.package].add(outputId);
       }
     }
-    return new BuildResult(BuildStatus.Success, BuildType.Full, outputs);
+    return new BuildResult(BuildStatus.success, BuildType.full, outputs);
   }
 
   /// Initializes the map of all the available inputs by package.

lib/src/generate/build_result.dart

@@ -27,7 +27,7 @@ class BuildResult {
 
   @override
   String toString() {
-    if (status == BuildStatus.Success) {
+    if (status == BuildStatus.success) {
       return '''
 
 Build Succeeded!
@@ -47,7 +47,7 @@ $stackTrace
 }
 
 /// The status of a build.
-enum BuildStatus { Success, Failure, }
+enum BuildStatus { success, failure, }
 
 /// The type of a build.
-enum BuildType { Incremental, Full }
+enum BuildType { incremental, full }

lib/src/generate/watch_impl.dart

@@ -156,7 +156,7 @@ class WatchImpl {
       _currentBuild.then((result) {
         // Terminate the watcher if the build script is updated, there is no
         // need to continue listening.
-        if (result.status == BuildStatus.Failure &&
+        if (result.status == BuildStatus.failure &&
             result.exception is FatalBuildException) {
           terminate();
         }

lib/src/package_graph/package_graph.dart

@@ -101,7 +101,7 @@ class PackageGraph {
     }
 
     var root =
-        addNodeAndDeps(rootYaml, PackageDependencyType.Path, isRoot: true);
+        addNodeAndDeps(rootYaml, PackageDependencyType.path, isRoot: true);
     return new PackageGraph._(root, nodes);
   }
 
@@ -152,20 +152,20 @@ class PackageNode {
 
 /// The type of dependency being used. This dictates how the package should be
 /// watched for changes.
-enum PackageDependencyType { Pub, Github, Path, }
+enum PackageDependencyType { pub, github, path }
 
 PackageDependencyType _dependencyType(source) {
-  if (source is String || source == null) return PackageDependencyType.Pub;
+  if (source is String || source == null) return PackageDependencyType.pub;
 
   assert(source is YamlMap);
   assert(source.keys.length == 1);
 
   var typeString = source.keys.first;
   switch (typeString) {
     case 'git':
-      return PackageDependencyType.Github;
+      return PackageDependencyType.github;
     case 'path':
-      return PackageDependencyType.Path;
+      return PackageDependencyType.path;
     default:
       throw 'Unrecognized package dependency type `$typeString`';
   }

pubspec.yaml

@@ -1,5 +1,5 @@
 name: build
-version: 0.2.2-dev
+version: 0.3.0-dev
 description: A build system for Dart.
 author: Dart Team <[email protected]>
 homepage: https://github.com/dart-lang/build

test/common/common.dart

@@ -75,7 +75,7 @@ Future testPhases(PhaseGroup phases, Map<String, String> inputs,
     {bool deleteFilesByDefault,
     Map<String, String> outputs,
     PackageGraph packageGraph,
-    BuildStatus status: BuildStatus.Success,
+    BuildStatus status: BuildStatus.success,
     Matcher exceptionMatcher,
     InMemoryAssetWriter writer}) async {
   writer ??= new InMemoryAssetWriter();

test/generate/build_test.dart

@@ -98,7 +98,7 @@ void main() {
             new CopyBuilder(), new InputSet('b', ['**/*']));
 
         await testPhases(phases, {'b|lib/b.txt': 'b'},
-            outputs: {}, status: BuildStatus.Failure);
+            outputs: {}, status: BuildStatus.failure);
       });
     });
 
@@ -142,7 +142,7 @@ void main() {
             'a|lib/a.txt.copy': 'a',
             'a|$assetGraphPath': JSON.encode(emptyGraph.serialize()),
           },
-          status: BuildStatus.Failure,
+          status: BuildStatus.failure,
           exceptionMatcher: invalidOutputException);
     });
   });

test/generate/watch_test.dart

@@ -146,16 +146,16 @@ void main() {
             ChangeType.MODIFY, path.absolute('a', 'web', 'a.txt')));
 
         result = await nextResult(results);
-        expect(result.status, BuildStatus.Failure);
+        expect(result.status, BuildStatus.failure);
       });
 
       test('ignores events from nested packages', () async {
         var writer = new InMemoryAssetWriter();
         var results = <BuildResult>[];
         var packageA = new PackageNode(
-            'a', '0.1.0', PackageDependencyType.Path, new Uri.file('a/'));
+            'a', '0.1.0', PackageDependencyType.path, new Uri.file('a/'));
         var packageB = new PackageNode(
-            'b', '0.1.0', PackageDependencyType.Path, new Uri.file('a/b/'));
+            'b', '0.1.0', PackageDependencyType.path, new Uri.file('a/b/'));
         packageA.dependencies.add(packageB);
         var packageGraph = new PackageGraph.fromRoot(packageA);