Skip to content

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Oct 16, 2024

  • Move and fix workflow files and badges in the README.md
  • Rev the version of the package, so that pub.dev points to the correct site
  • Add a line to the changelog:
* Move to `dart-lang/core` monorepo.
  • Add the package to the top-level readme of the monorepo:
| [platform](pkgs/platform/) | A pluggable, mockable platform information abstraction for Dart. | [![pub package](https://img.shields.io/pub/v/platform.svg)](https://pub.dev/packages/platform) |
> [!IMPORTANT]  
> This repo has moved to https://github.com/dart-lang/core/tree/main/pkgs/platform
  • Publish using the autopublish workflow
  • Push tags to GitHub using git tag --list 'platform*' | xargs git push origin
  • Close open PRs in dart-lang/platform with the following message:

Closing as the [dart-lang/platform](https://github.com/dart-lang/platform) repository is merged into the [dart-lang/core](https://github.com/dart-lang/core) monorepo. Please re-open this PR there!

  • Transfer issues by running dart run pkgs/repo_manage/bin/report.dart transfer-issues --source-repo dart-lang/platform --target-repo dart-lang/core --add-label package:platform --apply-changes
  • Archive https://github.com/dart-lang/platform/

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

tvolkert and others added 30 commits January 24, 2017 17:37
* add ansiSupported

* review comments
)

Update .gitignore to new `dart_tool` pub cache
* Update package:test dependency
* Declare compatibility with Dart 2 stable
* Fix Dart 2 errors
…rm#24)

Migrate platform to null-safety. Remove stable travis shard since that does not support null safety
publishable null-safety release

Co-authored-by: Jacob MacDonald <[email protected]>
…archive/platform#33)

This adds a copyWith function to FakePlatform so that it is easy to override just one value from another platform. This can cut down a lot on duplicate code in tests, since you can make one template platform, and then just customize bits of it in each test.

Also, updated travis.sh to work with "dart format" instead of "dartfmt", and bumped the version number.
…platform#34)

Fixed the Dart SDK constraint to no longer be a pre-release constraint (i.e. 2.12.0 instead of 2.12.0-0).

Also, added a pre-commit publish check.
@mosuem mosuem requested a review from devoncarew October 16, 2024 14:30
Copy link

github-actions bot commented Oct 16, 2024

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/platform/example/bin/example.dart 💔 Not covered
pkgs/platform/lib/platform.dart 💔 Not covered
pkgs/platform/lib/src/interface/local_platform.dart 💚 100 %
pkgs/platform/lib/src/interface/platform.dart 💚 75 %
pkgs/platform/lib/src/testing/fake_platform.dart 💚 99 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Copy link

github-actions bot commented Oct 16, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:platform 3.1.6 ready to publish platform-v3.1.6
package:args 2.6.1-wip WIP (no publish necessary)
package:async 2.12.0 already published at pub.dev
package:characters 1.3.1 already published at pub.dev
package:convert 3.1.2 already published at pub.dev
package:crypto 3.0.6 already published at pub.dev
package:fixnum 1.1.1 already published at pub.dev
package:logging 1.3.0 already published at pub.dev
package:os_detect 2.0.2 already published at pub.dev
package:path 1.9.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (note the one suggested change)

@mosuem mosuem merged commit 07aff97 into main Oct 17, 2024
21 checks passed
@mosuem mosuem deleted the merge-platform-package branch October 17, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.