-
Notifications
You must be signed in to change notification settings - Fork 33
Merge package:platform
#404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Minor doc updates
* add ansiSupported * review comments
* Update package:test dependency * Declare compatibility with Dart 2 stable * Fix Dart 2 errors
…rm#24) Migrate platform to null-safety. Remove stable travis shard since that does not support null safety
publishable null-safety release Co-authored-by: Jacob MacDonald <[email protected]>
* update sdk contraint for 2.11
…archive/platform#33) This adds a copyWith function to FakePlatform so that it is easy to override just one value from another platform. This can cut down a lot on duplicate code in tests, since you can make one template platform, and then just customize bits of it in each test. Also, updated travis.sh to work with "dart format" instead of "dartfmt", and bumped the version number.
…platform#34) Fixed the Dart SDK constraint to no longer be a pre-release constraint (i.e. 2.12.0 instead of 2.12.0-0). Also, added a pre-commit publish check.
…s. (dart-archive/platform#35) This removes Travis configuration and switches to GitHub actions. Also, updated the analysis options to use package:lints/recommended.yaml.
Merging on behalf of @mit-mit
…orm#40) drop broken coverage and CI badges
* Bring over latest files from flutter/packages * Replace Flutter example with Dart example
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
File | Coverage |
---|---|
pkgs/platform/example/bin/example.dart | 💔 Not covered |
pkgs/platform/lib/platform.dart | 💔 Not covered |
pkgs/platform/lib/src/interface/local_platform.dart | 💚 100 % |
pkgs/platform/lib/src/interface/platform.dart | 💚 75 % |
pkgs/platform/lib/src/testing/fake_platform.dart | 💚 99 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (note the one suggested change)
Co-authored-by: Devon Carew <[email protected]>
Allow merge commits
admin setting)git tag --list 'platform*' | xargs git push origin
Closing as the [dart-lang/platform](https://github.com/dart-lang/platform) repository is merged into the [dart-lang/core](https://github.com/dart-lang/core) monorepo. Please re-open this PR there!
dart run pkgs/repo_manage/bin/report.dart transfer-issues --source-repo dart-lang/platform --target-repo dart-lang/core --add-label package:platform --apply-changes
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.