Skip to content

fix(crypto): update conditional import for js interop library #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(crypto): update conditional import for js interop library #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d125750
fix(crypto): update conditional import for js interop library
tyllark Oct 7, 2025
2e70a4c
chore(crypto): Updated ChangeLog
tyllark Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/crypto/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Run `dart format` with the new style.
- Performance improvements.
- Updated web conditional import to use `js_interop` to support WebAssembly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Updated web conditional import to use `js_interop` to support WebAssembly
- Updated web conditional import to use `js_interop` to support WebAssembly.

;)


## 3.0.6

Expand Down
3 changes: 2 additions & 1 deletion pkgs/crypto/lib/src/sha512.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import 'dart:convert';
import 'digest.dart';
import 'hash.dart';
// ignore: uri_does_not_exist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Is this ignore really necessary?

import 'sha512_fastsinks.dart' if (dart.library.js) 'sha512_slowsinks.dart';
import 'sha512_fastsinks.dart'
if (dart.library.js_interop) 'sha512_slowsinks.dart';
import 'utils.dart';

/// An implementation of the [SHA-384][rfc] hash function.
Expand Down