Skip to content

Replace version info button with info icon on narrow screens #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −21
Open

Replace version info button with info icon on narrow screens #3468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 30 additions & 21 deletions pkgs/dartpad_ui/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@ class StatusLineWidget extends StatelessWidget {
),
),
const Expanded(child: SizedBox(width: defaultSpacing)),
VersionInfoWidget(appModel.runtimeVersions),
VersionInfoWidget(appModel.runtimeVersions, hideLabel: mobileVersion),
const SizedBox(width: denseSpacing),
SelectChannelWidget(hideLabel: mobileVersion),
],
Expand Down Expand Up @@ -1123,38 +1123,47 @@ class KeyBindingsTable extends StatelessWidget {

class VersionInfoWidget extends StatefulWidget {
final ValueListenable<VersionResponse?> versions;
final bool hideLabel;

const VersionInfoWidget(this.versions, {super.key});
const VersionInfoWidget(this.versions, {super.key, this.hideLabel = false});

@override
State<VersionInfoWidget> createState() => _VersionInfoWidgetState();
}

class _VersionInfoWidgetState extends State<VersionInfoWidget> {
bool hovered = false;
void _showVersionDialog(VersionResponse versions) {
showDialog<void>(
context: context,
builder: (context) => MediumDialog(
title: 'Runtime versions',
child: VersionTable(version: versions),
),
);
}

@override
Widget build(BuildContext context) {
return ValueListenableBuilder<VersionResponse?>(
valueListenable: widget.versions,
builder: (content, versions, _) {
if (versions == null) {
return const SizedBox();
}

return TextButton(
onPressed: () {
showDialog<void>(
context: context,
builder: (context) {
return MediumDialog(
title: 'Runtime versions',
child: VersionTable(version: versions),
);
},
);
},
child: Text(versions.label),
builder: (_, versions, _) {
if (versions == null) return const SizedBox();

return AnimatedSwitcher(
duration: const Duration(milliseconds: 200),
child: widget.hideLabel
? IconButton(
key: const ValueKey('info_icon'),
icon: const Icon(Icons.info_outline),
tooltip: 'Runtime versions',
onPressed: () => _showVersionDialog(versions),
)
: TextButton.icon(
key: const ValueKey('info_button'),
icon: const Icon(Icons.info_outline, size: 18),
label: Text(versions.label),
onPressed: () => _showVersionDialog(versions),
),
);
},
);
Expand Down