Skip to content

Tidy some tests after stable Dart release #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Tidy some tests after stable Dart release #3839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions test/class_modifiers_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ class ClassModifiersTest extends DartdocTestBase {
@override
String get libraryName => 'class_modifiers';

@override
String get sdkConstraint => '>=3.0.0-0.0-dev <4.0.0';

@override
List<String> get experiments => ['class-modifiers', 'sealed-class'];

/// From the table in the class modifiers feature specification.
void test_tableOfModifiers() async {
var library = await bootPackageWithLibrary('''
Expand Down
12 changes: 0 additions & 12 deletions test/constant_values_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ import 'src/utils.dart';
void main() {
defineReflectiveSuite(() {
defineReflectiveTests(ConstantValuesTest);
if (namedArgumentsAnywhereAllowed) {
defineReflectiveTests(ConstantValuesWithNamedArgumentsAnywhereTest);
}
defineReflectiveTests(HiddenConstantsTest);
});
}
Expand Down Expand Up @@ -132,15 +129,6 @@ const aTearOffUnnamedConstructorArgsTypedef = Ft<String>.new;
expect(aTearOffUnnamedConstructorArgsTypedef.constantValue,
equals('Ft&lt;String&gt;.new'));
}
}

@reflectiveTest
class ConstantValuesWithNamedArgumentsAnywhereTest extends DartdocTestBase {
@override
String get libraryName => 'constant_values';

@override
String get sdkConstraint => '>=2.17.0 <3.0.0';

void test_namedParametersInConstInvocationValue_specifiedLast() async {
var library = await bootPackageWithLibrary('''
Expand Down
6 changes: 0 additions & 6 deletions test/extension_types_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,9 @@ void main() {

@reflectiveTest
class ExtensionTypesTest extends DartdocTestBase {
@override
List<String> get experiments => ['inline-class'];

@override
String get libraryName => 'extension_types';

@override
String get sdkConstraint => '>=3.3.0 <4.0.0';

// TODO(srawlins): Test superinterfaces, references to members which exist via
// `implements`, references to primary constructor.

Expand Down
3 changes: 0 additions & 3 deletions test/record_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ class RecordTest extends DartdocTestBase {
@override
String get libraryName => 'records';

@override
String get sdkConstraint => '>=3.0.0 <4.0.0';

void test_noFields() async {
var library = await bootPackageWithLibrary('''
void f(() r) {}
Expand Down
6 changes: 0 additions & 6 deletions test/typedef_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,9 @@ void main() {

@reflectiveTest
class TypedefTest extends DartdocTestBase {
@override
List<String> get experiments => ['inline-class'];

@override
String get libraryName => 'typedefs';

@override
String get sdkConstraint => '>=3.3.0 <4.0.0';

void test_class_basic() async {
var library = await bootPackageWithLibrary('''
class C {}
Expand Down
2 changes: 1 addition & 1 deletion tool/task.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,7 @@ Rebuild them with "dart tool/task.dart build" and check the results in.
bool get _analyzerInUseIsTarget {
// TODO(srawlins): Add validation that this number falls within the
// constraints of the analyzer package which are set in `pubspec.yaml`.
const analyzerTarget = '6.5.2';
const analyzerTarget = '6.8.0';

var lockfilePath = path.join(Directory.current.path, 'pubspec.lock');
var lockfile = loadYaml(File(lockfilePath).readAsStringSync()) as YamlMap;
Expand Down