Skip to content

Add environment to SubprocessException, for improved debugging #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add environment to SubprocessException, for improved debugging #3841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions tool/src/subprocess_launcher.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,11 @@ class SubprocessLauncher {

if (exitCode != 0) {
throw SubprocessException(
command: [executable, ...arguments].join(' '),
workingDirectory: workingDirectory,
exitCode: exitCode);
command: [executable, ...arguments].join(' '),
workingDirectory: workingDirectory,
exitCode: exitCode,
environment: environment,
);
}
return jsonObjects;
}
Expand Down Expand Up @@ -182,15 +184,19 @@ class SubprocessException implements Exception {
final String command;
final String? workingDirectory;
final int exitCode;
final Map<String, String> environment;

SubprocessException(
{required this.command,
required this.workingDirectory,
required this.exitCode});
SubprocessException({
required this.command,
required this.workingDirectory,
required this.environment,
required this.exitCode,
});

@override
String toString() => 'SubprocessException['
'command: "$command", '
'workingDirectory: "${workingDirectory ?? '(null)'}", '
'exitCode: $exitCode]';
'exitCode: $exitCode, '
'environment: $environment]';
}