Skip to content

Conversation

srawlins
Copy link
Member

Not a big deal, but this trims newlines both from the checked in AOT template renderers (~500 newlines), and also from the rendered HTML output. I wanted to play with the idea and found the impl so simple that it seems like an easy win.

Fewer blank lines in the rendered HTML make it easier to scroll through in a failed unit test, or a log, or on disk. A single removed line in a generated AOT template renderer could be something that is executed in a loop, representing n removed newlines in the rendered HTML. (It's also fewer bytes but I would be surprised if that was anything but negligible.)


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins
Copy link
Member Author

CC @dart-lang/analyzer-team

@srawlins srawlins merged commit c10962e into dart-lang:main Aug 30, 2024
9 checks passed
@srawlins srawlins deleted the less-whitespace branch August 31, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants