Trim blank lines from generated renderers #3857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a big deal, but this trims newlines both from the checked in AOT template renderers (~500 newlines), and also from the rendered HTML output. I wanted to play with the idea and found the impl so simple that it seems like an easy win.
Fewer blank lines in the rendered HTML make it easier to scroll through in a failed unit test, or a log, or on disk. A single removed line in a generated AOT template renderer could be something that is executed in a loop, representing n removed newlines in the rendered HTML. (It's also fewer bytes but I would be surprised if that was anything but negligible.)
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.