Skip to content

Conversation

@devoncarew
Copy link
Contributor

  • update test expectation for newer versions of package:args

A not-yet-published version of package:args will change the exception's message from Could not find an option named "nonexistent" to Could not find an option named "--nonexistent"; this adjusts the test expectation to work for either package:args version.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Contributor Author

(this update will allow us to roll the latest package:args into the sdk and google3)

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@devoncarew devoncarew merged commit 5c114a9 into main Oct 8, 2024
9 checks passed
@devoncarew devoncarew deleted the update_test_expectation branch October 8, 2024 22:12
@devoncarew
Copy link
Contributor Author

Hmm, it looks like I'm still seeing a failure from https://github.com/dart-lang/dartdoc/blob/main/test/documentation_comment_test.dart#L454; we should relax that check as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants