Skip to content

Conversation

@srawlins
Copy link
Member

The "enhanced enums" test class, at this point, has a lower SDK constraint than the other enums test class. Just combine them.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

The "enhanced enums" test class, at this point, has a _lower_ SDK constraint
than the other enums test class. Just combine them.

@override
String get sdkConstraint => '>=2.17.0 <3.0.0';
void test_annotatedValue() async {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big diff is because I sorted the test cases. No content is changed.

@srawlins
Copy link
Member Author

CC @dart-lang/analyzer-team

@srawlins srawlins merged commit c8be845 into dart-lang:main Dec 19, 2024
7 checks passed
@srawlins srawlins deleted the combine-enums branch December 19, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants