Skip to content

Conversation

@keertip
Copy link
Collaborator

@keertip keertip commented Jan 27, 2025

Element model migration. Migrate

  • lib/src/model/canonicalization.dart
  • lib/src/type_utils.dart
  • test/mustachio/builder_test_base.dart

@keertip keertip requested a review from srawlins January 27, 2025 16:33
}
}
}
var buffer = StringBuffer();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not formatted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

}
}

String _getElementLocation(Element2 element) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a comment about where this comes from, so that we can look to the other implementation if bugs arise?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@keertip keertip merged commit 114c006 into dart-lang:main Jan 27, 2025
9 checks passed
@keertip keertip deleted the migrateElements branch January 27, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants