Skip to content

Conversation

@keertip
Copy link
Collaborator

@keertip keertip commented Jan 29, 2025

Migrate

  • lib/src/model/inheritable.dart
  • lib/src/model/never.dart
  • lib/src/model/parameter.dart
  • lib/src/model/prefix.dart
  • lib/src/model/typedef.dart


import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/dart/element/element2.dart';
// ignore: implementation_imports
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to remember to search for imports of these extensions before we declare the package fully converted.

Alternatively, you could remove element and use .element2.asElement in any unconverted files. That might be less error prone.

Copy link
Collaborator Author

@keertip keertip Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Will use that moving forward and change these in a follow up CL.

// ignore: implementation_imports
import 'package:analyzer/src/dart/element/member.dart' show ParameterMember;
// ignore: implementation_imports
import 'package:analyzer/src/utilities/extensions/element.dart';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@keertip keertip merged commit ca594a3 into dart-lang:main Jan 29, 2025
9 checks passed
@keertip keertip deleted the migrate3 branch January 29, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants