Remove use of deprecated parameter #4035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the use of `updateAnalysisOptions2` with a use of `updateAnalysisOptions3`. The latter callback has one fewer parameter, but since we weren't using that parameter no other changes (other than import cleanup) are required.
|
I'm not sure what's causing the failures. |
srawlins
approved these changes
Apr 18, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 22, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/62aefbb..1788710): 17887101 2025-04-18 Brian Wilkerson Remove use of deprecated parameter (dart-lang/dartdoc#4035) http (https://github.com/dart-lang/http/compare/e4ddd3e..63c477b): 63c477b 2025-04-17 Brian Quinlan Ready for release: cupertino_http, web_socket, web_socket_channel (dart-lang/http#1753) 03eb8de 2025-04-16 Brian Quinlan Prepare for a `package:web_socket` 1.0 release (dart-lang/http#1738) test (https://github.com/dart-lang/test/compare/84eba11..3ac991f): 3ac991fa 2025-04-17 Nate Bosch Fix typos in README (dart-lang/test#2487) vector_math (https://github.com/google/vector_math.dart/compare/dc9d379..39cafd4): 39cafd4 2025-04-15 Devon Carew prep for publishing 2.1.5 (google/vector_math.dart#344) Change-Id: Ifc1f01d58551a08aa3bf247ce05f4a903c869a59 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423604 Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Devon Carew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the use of
updateAnalysisOptions2with a use ofupdateAnalysisOptions3. The latter callback has one fewer parameter, but since we weren't using that parameter no other changes (other than import cleanup) are required.