Canonicalize elements in remote packages

lib/src/generator/templates.runtime_renderers.dart

@@ -26156,6 +26156,7 @@ const _invisibleGetters = {
     'libraryCount',
     'libraryExports',
     'libraryExports2',
+    'localLibraries',
     'localPackages',
     'localPublicLibraries',
     'name',

lib/src/model/model_element.dart

@@ -512,11 +512,15 @@ abstract class ModelElement
     // This is not accurate if we are still constructing the Package.
     assert(packageGraph.allLibrariesAdded);
 
-    var definingLibraryIsLocalPublic =
-        packageGraph.localPublicLibraries.contains(library);
-    var possibleCanonicalLibrary = definingLibraryIsLocalPublic
-        ? library
-        : canonicalLibraryCandidate(this);
+    var isLocalLibrary = packageGraph.localLibraries.contains(library);
+    if (!isLocalLibrary && !config.linkToRemote) {
+      return null;
+    }
+
+    var definingLibraryIsPublic =
+        packageGraph.publicLibraries.contains(library);
+    var possibleCanonicalLibrary =
+        definingLibraryIsPublic ? library : canonicalLibraryCandidate(this);
 
     if (possibleCanonicalLibrary != null) return possibleCanonicalLibrary;
 

lib/src/model/package_graph.dart

@@ -679,15 +679,15 @@ class PackageGraph with CommentReferable, Nameable {
     return libraries.wherePublic.toSet();
   }();
 
-  late final List<Library> _localLibraries = () {
+  late final List<Library> localLibraries = () {
     assert(allLibrariesAdded);
     return localPackages.expand((p) => p.libraries).toList(growable: false)
       ..sort();
   }();
 
   late final Set<Library> localPublicLibraries = () {
     assert(allLibrariesAdded);
-    return _localLibraries.wherePublic.toSet();
+    return localLibraries.wherePublic.toSet();
   }();
 
   /// The String name representing the `Object` type.

test/end2end/model_test.dart

@@ -1834,7 +1834,7 @@ void main() async {
 
   group('Class', () {
     late final List<Class> classes;
-    late final Class Apple, B, Cat, Dog, F, Dep, SpecialList;
+    late final Class Apple, B, Cat, Dog, F, Helper, SpecialList;
     late final Class ExtendingClass, CatString;
 
     setUpAll(() {
@@ -1844,7 +1844,7 @@ void main() async {
       Cat = classes.named('Cat');
       Dog = classes.named('Dog');
       F = classes.named('F');
-      Dep = classes.named('Deprecated');
+      Helper = classes.named('Helper');
       SpecialList = fakeLibrary.classes.named('SpecialList');
       ExtendingClass = twoExportsLib.classes.named('ExtendingClass');
       CatString = exLibrary.classes.named('CatString');
@@ -1879,7 +1879,7 @@ void main() async {
     });
 
     test('correctly finds all the classes', () {
-      expect(classes, hasLength(34));
+      expect(classes, hasLength(33));
     });
 
     test('abstract', () {
@@ -1982,10 +1982,9 @@ void main() async {
     });
 
     test('exported class should have hrefs from the current library', () {
-      expect(
-          Dep.href, equals('${htmlBasePlaceholder}ex/Deprecated-class.html'));
-      expect(Dep.instanceMethods.named('toString').href,
-          equals('${htmlBasePlaceholder}ex/Deprecated/toString.html'));
+      expect(Helper.href, equals('${htmlBasePlaceholder}ex/Helper-class.html'));
+      expect(Helper.instanceMethods.named('toString').href,
+          equals('${htmlBasePlaceholder}ex/Helper/toString.html'));
     });
 
     test('F has a single instance method', () {

test/packages_test.dart

@@ -263,6 +263,7 @@ library bar;
             .writeAsStringSync('''
 /// Documentation comment.
 library one;
+export 'some_other_lib.dart' show Exported;
 
 class One {}
 ''');
@@ -276,6 +277,10 @@ library script;
 
 class Script {}
 ''');
+        packageOneRoot
+            .getChildAssumingFolder('lib')
+            .getChildAssumingFile('some_other_lib.dart')
+            .writeAsStringSync('''class Exported {}''');
 
         packageTwoRoot =
             utils.writePackage('two', resourceProvider, packageConfigProvider);
@@ -316,6 +321,12 @@ dartdoc:
         expect(packageOne.documentedWhere, equals(DocumentLocation.remote));
         expect(classOne.href,
             equals('https://mypub.topdomain/one/0.0.1/one/One-class.html'));
+        // Validate that canonicalization takes place for remote packages.
+        var exported = libraryOne.classes.named('Exported');
+        expect(
+            exported.href,
+            equals(
+                'https://mypub.topdomain/one/0.0.1/some_other_lib/Exported-class.html'));
       });
 
       test(