Skip to content

Conversation

@szakarias
Copy link
Contributor

@szakarias szakarias commented Sep 5, 2025

Following TODO added in #4060

@szakarias szakarias force-pushed the removeRuntimeRenderer branch from 67cad8d to de0b626 Compare September 5, 2025 11:54
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please leave a reference to why we can remove this

@szakarias
Copy link
Contributor Author

cc @srawlins

@srawlins
Copy link
Member

srawlins commented Sep 5, 2025

❤️ 💯

Yep, the runtime renderers are no longer needed :D

@srawlins
Copy link
Member

srawlins commented Sep 5, 2025

Nothing like deleting 30k lines on a Friday, drop the mic, walk away, weekend.

@szakarias szakarias force-pushed the removeRuntimeRenderer branch from de0b626 to 5280d3e Compare September 5, 2025 19:34
@szakarias szakarias merged commit efff7c1 into dart-lang:main Sep 8, 2025
11 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 9, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/1547a83..bc90433):
  bc90433  2025-09-04  Greg Spencer  Add pub add format guidance (dart-lang/ai#278)
  845c126  2025-09-04  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/ai#277)
  5568958  2025-09-04  Jacob MacDonald  add a GEMINI.md file (dart-lang/ai#279)

core (https://github.com/dart-lang/core/compare/5c3e2c3..a4dc873):
  a4dc8738  2025-09-09  Ömer Sinan Ağacan  Implement `Int64` as a wrapper for `int` when targeting native and Wasm (dart-lang/core#905)
  1aa58ef5  2025-09-08  Devon Carew  [fixnum] update the min. required dart sdk (dart-lang/core#907)
  60f2b5d3  2025-09-08  Ömer Sinan Ağacan  Run fixnum tests with dart2wasm (dart-lang/core#906)

dartdoc (https://github.com/dart-lang/dartdoc/compare/53222e2..efff7c1):
  efff7c1f  2025-09-08  Sarah Zakarias  Remove  runtime_renderers.dart (dart-lang/dartdoc#4101)
  4e2daf57  2025-09-05  Sarah Zakarias  Rename LanguageFeature and remove FeatureSet mixin (dart-lang/dartdoc#4099)
  ecc48d00  2025-09-02  dependabot[bot]  Bump the github-actions group across 1 directory with 3 updates (dart-lang/dartdoc#4098)

protobuf (https://github.com/dart-lang/protobuf/compare/0a13935..971bcae):
  971bcae  2025-09-08  Ömer Sinan Ağacan  Use a map to cache the `valueOf` functions for enums (google/protobuf.dart#1047)
  8750ed7  2025-09-05  Ömer Sinan Ağacan  Sync internal Kythe support improvements (google/protobuf.dart#1048)

web (https://github.com/dart-lang/web/compare/a152054..e2daa3a):
  e2daa3a  2025-09-04  Nikechukwu  [interop] Add support for Intersection types (dart-lang/web#451)

webdev (https://github.com/dart-lang/webdev/compare/52ad019..23aefeb):
  23aefebe  2025-09-05  jensjoha  Fix CI flake in dwds/test/hot_restart_breakpoints_test.dart (dart-lang/webdev#2685)

Change-Id: I36cfbcdd884e8e0e38e24a9c7f3bcfcc15fdd9ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449000
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants