Skip to content

run the health checks in fewer github jobs #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

run the health checks in fewer github jobs #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 4 additions & 84 deletions .github/workflows/health.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ name: Health
# jobs:
# health:
# uses: dart-lang/ecosystem/.github/workflows/health.yaml@main


#
# Or with options:
#
# jobs:
Expand Down Expand Up @@ -148,12 +147,11 @@ on:
required: false

jobs:
changelog:
if: ${{ contains(inputs.checks, 'changelog') }}
health_checks:
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
check: changelog
check: ${{ inputs.checks }}
fail_on: ${{ inputs.fail_on }}
warn_on: ${{ inputs.warn_on }}
local_debug: ${{ inputs.local_debug }}
Expand All @@ -163,86 +161,8 @@ jobs:
checkout_submodules: ${{ inputs.checkout_submodules }}
health_yaml_name: ${{ inputs.health_yaml_name }}

license:
if: ${{ contains(inputs.checks, 'license') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
check: license
fail_on: ${{ inputs.fail_on }}
warn_on: ${{ inputs.warn_on }}
local_debug: ${{ inputs.local_debug }}
flutter_packages: ${{ inputs.flutter_packages }}
ignore_license: ${{ inputs.ignore_license }}
ignore_packages: ${{ inputs.ignore_packages }}
checkout_submodules: ${{ inputs.checkout_submodules }}
health_yaml_name: ${{ inputs.health_yaml_name }}

coverage:
if: ${{ contains(inputs.checks, 'coverage') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
check: coverage
fail_on: ${{ inputs.fail_on }}
warn_on: ${{ inputs.warn_on }}
upload_coverage: ${{ inputs.upload_coverage }}
coverage_web: ${{ inputs.coverage_web }}
local_debug: ${{ inputs.local_debug }}
flutter_packages: ${{ inputs.flutter_packages }}
ignore_coverage: ${{ inputs.ignore_coverage }}
ignore_packages: ${{ inputs.ignore_packages }}
checkout_submodules: ${{ inputs.checkout_submodules }}
experiments: ${{ inputs.experiments }}
health_yaml_name: ${{ inputs.health_yaml_name }}

breaking:
if: ${{ contains(inputs.checks, 'breaking') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
check: breaking
fail_on: ${{ inputs.fail_on }}
warn_on: ${{ inputs.warn_on }}
local_debug: ${{ inputs.local_debug }}
flutter_packages: ${{ inputs.flutter_packages }}
ignore_breaking: ${{ inputs.ignore_breaking }}
ignore_packages: ${{ inputs.ignore_packages }}
checkout_submodules: ${{ inputs.checkout_submodules }}
health_yaml_name: ${{ inputs.health_yaml_name }}

do-not-submit:
if: ${{ contains(inputs.checks, 'do-not-submit') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
check: do-not-submit
fail_on: ${{ inputs.fail_on }}
warn_on: ${{ inputs.warn_on }}
local_debug: ${{ inputs.local_debug }}
flutter_packages: ${{ inputs.flutter_packages }}
ignore_donotsubmit: ${{ inputs.ignore_donotsubmit }}
ignore_packages: ${{ inputs.ignore_packages }}
checkout_submodules: ${{ inputs.checkout_submodules }}
health_yaml_name: ${{ inputs.health_yaml_name }}

leaking:
if: ${{ contains(inputs.checks, 'leaking') }}
uses: ./.github/workflows/health_base.yaml
with:
sdk: ${{ inputs.sdk }}
check: leaking
fail_on: ${{ inputs.fail_on }}
warn_on: ${{ inputs.warn_on }}
local_debug: ${{ inputs.local_debug }}
flutter_packages: ${{ inputs.flutter_packages }}
ignore_leaking: ${{ inputs.ignore_leaking }}
ignore_packages: ${{ inputs.ignore_packages }}
checkout_submodules: ${{ inputs.checkout_submodules }}
health_yaml_name: ${{ inputs.health_yaml_name }}

comment:
needs: [changelog, license, coverage, breaking, do-not-submit, leaking]
needs: [health_checks]
if: always()
# These permissions are required for us to create comments on PRs.
permissions:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/health_base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

name: Health:Base

# The workflow doing the checks for `health.yaml`. Not meant to be used externally.
# The workflow doing the checks for `health.yaml`. Not meant to be used
# externally.

on:
workflow_call:
Expand Down
Loading