Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/firehose/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Make the PR health output less verbose by collapsing warnings by default.
- Bump dart_apitool to fix errors with equal types being reported as different.
- Give comment files in health work.
- Don't ignore workspace pubspecs.

## 0.12.0

Expand Down
9 changes: 6 additions & 3 deletions pkgs/firehose/lib/src/repo.dart
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,14 @@ class Repository {
if (pubspecFile.existsSync()) {
var pubspec = yaml.loadYaml(pubspecFile.readAsStringSync()) as Map;
var publishTo = pubspec['publish_to'] as String?;
if (publishTo != 'none' && !pubspec.containsKey('workspace')) {
if (publishTo != 'none') {
print('Found published package at $directory');
packages.add(Package(directory, this));
// There is an assumption here that published, non-workspace packages do
// not contain nested published packages.
// There is an assumption here that published packages do not contain
// nested published packages.
return;
} else {
print('Ignoring non-published package at $directory');
}
}
if (directory.existsSync()) {
Expand Down
3 changes: 3 additions & 0 deletions pkgs/firehose/test_data/workspace_repo/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
name: workspace

publish_to: none

workspace:
- pkg_1
- pkg_2