Enable and fix lint prefer_single_quotes (#304)

natebosch · web-flow · commit e1f48230864d · 2019-09-12T11:06:20.000-07:00
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -3,5 +3,6 @@ linter:
   rules:
   - annotate_overrides
   - prefer_generic_function_type_aliases
+  - prefer_single_quotes
   - unnecessary_const
   - unnecessary_new
diff --git a/example/main.dart b/example/main.dart
@@ -4,15 +4,15 @@ import 'package:http/http.dart' as http;
 main(List<String> arguments) async {
   // This example uses the Google Books API to search for books about http.
   // https://developers.google.com/books/docs/overview
-  var url = "https://www.googleapis.com/books/v1/volumes?q={http}";
+  var url = 'https://www.googleapis.com/books/v1/volumes?q={http}';
 
   // Await the http get response, then decode the json-formatted response.
   var response = await http.get(url);
   if (response.statusCode == 200) {
     var jsonResponse = convert.jsonDecode(response.body);
     var itemCount = jsonResponse['totalItems'];
-    print("Number of books about http: $itemCount.");
+    print('Number of books about http: $itemCount.');
   } else {
-    print("Request failed with status: ${response.statusCode}.");
+    print('Request failed with status: ${response.statusCode}.');
   }
 }
diff --git a/lib/src/base_client.dart b/lib/src/base_client.dart
@@ -23,15 +23,15 @@ abstract class BaseClient implements Client {
   /// For more fine-grained control over the request, use [send] instead.
   @override
   Future<Response> head(url, {Map<String, String> headers}) =>
-      _sendUnstreamed("HEAD", url, headers);
+      _sendUnstreamed('HEAD', url, headers);
 
   /// Sends an HTTP GET request with the given headers to the given URL, which
   /// can be a [Uri] or a [String].
   ///
   /// For more fine-grained control over the request, use [send] instead.
   @override
   Future<Response> get(url, {Map<String, String> headers}) =>
-      _sendUnstreamed("GET", url, headers);
+      _sendUnstreamed('GET', url, headers);
 
   /// Sends an HTTP POST request with the given headers and body to the given
   /// URL, which can be a [Uri] or a [String].
@@ -54,7 +54,7 @@ abstract class BaseClient implements Client {
   @override
   Future<Response> post(url,
           {Map<String, String> headers, body, Encoding encoding}) =>
-      _sendUnstreamed("POST", url, headers, body, encoding);
+      _sendUnstreamed('POST', url, headers, body, encoding);
 
   /// Sends an HTTP PUT request with the given headers and body to the given
   /// URL, which can be a [Uri] or a [String].
@@ -77,7 +77,7 @@ abstract class BaseClient implements Client {
   @override
   Future<Response> put(url,
           {Map<String, String> headers, body, Encoding encoding}) =>
-      _sendUnstreamed("PUT", url, headers, body, encoding);
+      _sendUnstreamed('PUT', url, headers, body, encoding);
 
   /// Sends an HTTP PATCH request with the given headers and body to the given
   /// URL, which can be a [Uri] or a [String].
@@ -100,15 +100,15 @@ abstract class BaseClient implements Client {
   @override
   Future<Response> patch(url,
           {Map<String, String> headers, body, Encoding encoding}) =>
-      _sendUnstreamed("PATCH", url, headers, body, encoding);
+      _sendUnstreamed('PATCH', url, headers, body, encoding);
 
   /// Sends an HTTP DELETE request with the given headers to the given URL,
   /// which can be a [Uri] or a [String].
   ///
   /// For more fine-grained control over the request, use [send] instead.
   @override
   Future<Response> delete(url, {Map<String, String> headers}) =>
-      _sendUnstreamed("DELETE", url, headers);
+      _sendUnstreamed('DELETE', url, headers);
 
   /// Sends an HTTP GET request with the given headers to the given URL, which
   /// can be a [Uri] or a [String], and returns a Future that completes to the
@@ -181,12 +181,12 @@ abstract class BaseClient implements Client {
   /// Throws an error if [response] is not successful.
   void _checkResponseSuccess(url, Response response) {
     if (response.statusCode < 400) return;
-    var message = "Request to $url failed with status ${response.statusCode}";
+    var message = 'Request to $url failed with status ${response.statusCode}';
     if (response.reasonPhrase != null) {
-      message = "$message: ${response.reasonPhrase}";
+      message = '$message: ${response.reasonPhrase}';
     }
     if (url is String) url = Uri.parse(url);
-    throw ClientException("$message.", url);
+    throw ClientException('$message.', url);
   }
 
   /// Closes the client and cleans up any resources associated with it. It's
diff --git a/lib/src/base_request.dart b/lib/src/base_request.dart
@@ -34,7 +34,7 @@ abstract class BaseRequest {
 
   set contentLength(int value) {
     if (value != null && value < 0) {
-      throw ArgumentError("Invalid content length $value.");
+      throw ArgumentError('Invalid content length $value.');
     }
     _checkFinalized();
     _contentLength = value;
diff --git a/lib/src/base_response.dart b/lib/src/base_response.dart
@@ -44,9 +44,9 @@ abstract class BaseResponse {
       this.persistentConnection = true,
       this.reasonPhrase}) {
     if (statusCode < 100) {
-      throw ArgumentError("Invalid status code $statusCode.");
+      throw ArgumentError('Invalid status code $statusCode.');
     } else if (contentLength != null && contentLength < 0) {
-      throw ArgumentError("Invalid content length $contentLength.");
+      throw ArgumentError('Invalid content length $contentLength.');
     }
   }
 }
diff --git a/lib/src/browser_client.dart b/lib/src/browser_client.dart
@@ -80,7 +80,7 @@ class BrowserClient extends BaseClient {
       // Unfortunately, the underlying XMLHttpRequest API doesn't expose any
       // specific information about the error itself.
       completer.completeError(
-          ClientException("XMLHttpRequest error.", request.url),
+          ClientException('XMLHttpRequest error.', request.url),
           StackTrace.current);
     }));
 
diff --git a/lib/src/multipart_file.dart b/lib/src/multipart_file.dart
@@ -49,7 +49,7 @@ class MultipartFile {
       : this._stream = toByteStream(stream),
         this.contentType = contentType != null
             ? contentType
-            : MediaType("application", "octet-stream");
+            : MediaType('application', 'octet-stream');
 
   /// Creates a new [MultipartFile] from a byte array.
   ///
@@ -71,7 +71,7 @@ class MultipartFile {
   factory MultipartFile.fromString(String field, String value,
       {String filename, MediaType contentType}) {
     contentType =
-        contentType == null ? MediaType("text", "plain") : contentType;
+        contentType == null ? MediaType('text', 'plain') : contentType;
     var encoding = encodingForCharset(contentType.parameters['charset'], utf8);
     contentType = contentType.change(parameters: {'charset': encoding.name});
 
diff --git a/lib/src/multipart_request.dart b/lib/src/multipart_request.dart
@@ -12,7 +12,7 @@ import 'byte_stream.dart';
 import 'multipart_file.dart';
 import 'utils.dart';
 
-final _newlineRegExp = RegExp(r"\r\n|\r|\n");
+final _newlineRegExp = RegExp(r'\r\n|\r|\n');
 
 /// A `multipart/form-data` request.
 ///
@@ -58,30 +58,30 @@ class MultipartRequest extends BaseRequest {
     var length = 0;
 
     fields.forEach((name, value) {
-      length += "--".length +
+      length += '--'.length +
           _boundaryLength +
-          "\r\n".length +
+          '\r\n'.length +
           utf8.encode(_headerForField(name, value)).length +
           utf8.encode(value).length +
-          "\r\n".length;
+          '\r\n'.length;
     });
 
     for (var file in _files) {
-      length += "--".length +
+      length += '--'.length +
           _boundaryLength +
-          "\r\n".length +
+          '\r\n'.length +
           utf8.encode(_headerForFile(file)).length +
           file.length +
-          "\r\n".length;
+          '\r\n'.length;
     }
 
-    return length + "--".length + _boundaryLength + "--\r\n".length;
+    return length + '--'.length + _boundaryLength + '--\r\n'.length;
   }
 
   @override
   set contentLength(int value) {
-    throw UnsupportedError("Cannot set the contentLength property of "
-        "multipart requests.");
+    throw UnsupportedError('Cannot set the contentLength property of '
+        'multipart requests.');
   }
 
   /// Freezes all mutable fields and returns a single-subscription [ByteStream]
@@ -158,17 +158,17 @@ class MultipartRequest extends BaseRequest {
     // follow this at all. Instead, they URL-encode `\r`, `\n`, and `\r\n` as
     // `\r\n`; URL-encode `"`; and do nothing else (even for `%` or non-ASCII
     // characters). We follow their behavior.
-    return value.replaceAll(_newlineRegExp, "%0D%0A").replaceAll('"', "%22");
+    return value.replaceAll(_newlineRegExp, '%0D%0A').replaceAll('"', '%22');
   }
 
   /// Returns a randomly-generated multipart boundary string
   String _boundaryString() {
-    var prefix = "dart-http-boundary-";
+    var prefix = 'dart-http-boundary-';
     var list = List<int>.generate(
         _boundaryLength - prefix.length,
         (index) =>
             BOUNDARY_CHARACTERS[_random.nextInt(BOUNDARY_CHARACTERS.length)],
         growable: false);
-    return "$prefix${String.fromCharCodes(list)}";
+    return '$prefix${String.fromCharCodes(list)}';
   }
 }
diff --git a/lib/src/request.dart b/lib/src/request.dart
@@ -23,8 +23,8 @@ class Request extends BaseRequest {
 
   @override
   set contentLength(int value) {
-    throw UnsupportedError("Cannot set the contentLength property of "
-        "non-streaming Request objects.");
+    throw UnsupportedError('Cannot set the contentLength property of '
+        'non-streaming Request objects.');
   }
 
   /// The default encoding to use when converting between [bodyBytes] and
@@ -87,7 +87,7 @@ class Request extends BaseRequest {
     bodyBytes = encoding.encode(value);
     var contentType = _contentType;
     if (contentType == null) {
-      _contentType = MediaType("text", "plain", {'charset': encoding.name});
+      _contentType = MediaType('text', 'plain', {'charset': encoding.name});
     } else if (!contentType.parameters.containsKey('charset')) {
       _contentType = contentType.change(parameters: {'charset': encoding.name});
     }
@@ -110,7 +110,7 @@ class Request extends BaseRequest {
   Map<String, String> get bodyFields {
     var contentType = _contentType;
     if (contentType == null ||
-        contentType.mimeType != "application/x-www-form-urlencoded") {
+        contentType.mimeType != 'application/x-www-form-urlencoded') {
       throw StateError('Cannot access the body fields of a Request without '
           'content-type "application/x-www-form-urlencoded".');
     }
@@ -121,8 +121,8 @@ class Request extends BaseRequest {
   set bodyFields(Map<String, String> fields) {
     var contentType = _contentType;
     if (contentType == null) {
-      _contentType = MediaType("application", "x-www-form-urlencoded");
-    } else if (contentType.mimeType != "application/x-www-form-urlencoded") {
+      _contentType = MediaType('application', 'x-www-form-urlencoded');
+    } else if (contentType.mimeType != 'application/x-www-form-urlencoded') {
       throw StateError('Cannot set the body fields of a Request with '
           'content-type "${contentType.mimeType}".');
     }
diff --git a/lib/src/response.dart b/lib/src/response.dart
@@ -82,5 +82,5 @@ Encoding _encodingForHeaders(Map<String, String> headers) =>
 MediaType _contentTypeForHeaders(Map<String, String> headers) {
   var contentType = headers['content-type'];
   if (contentType != null) return MediaType.parse(contentType);
-  return MediaType("application", "octet-stream");
+  return MediaType('application', 'octet-stream');
 }
diff --git a/lib/src/utils.dart b/lib/src/utils.dart
@@ -18,7 +18,7 @@ String mapToQuery(Map<String, String> map, {Encoding encoding}) {
         Uri.encodeQueryComponent(key, encoding: encoding),
         Uri.encodeQueryComponent(value, encoding: encoding)
       ]));
-  return pairs.map((pair) => "${pair[0]}=${pair[1]}").join("&");
+  return pairs.map((pair) => '${pair[0]}=${pair[1]}').join('&');
 }
 
 /// Like [String.split], but only splits on the first occurrence of the pattern.
@@ -58,7 +58,7 @@ Encoding requiredEncodingForCharset(String charset) {
 
 /// A regular expression that matches strings that are composed entirely of
 /// ASCII-compatible characters.
-final RegExp _ASCII_ONLY = RegExp(r"^[\x00-\x7F]+$");
+final RegExp _ASCII_ONLY = RegExp(r'^[\x00-\x7F]+$');
 
 /// Returns whether [string] is composed entirely of ASCII-compatible
 /// characters.
diff --git a/test/html/client_test.dart b/test/html/client_test.dart
@@ -13,7 +13,7 @@ import 'utils.dart';
 void main() {
   test('#send a StreamedRequest', () {
     var client = BrowserClient();
-    var request = http.StreamedRequest("POST", echoUrl);
+    var request = http.StreamedRequest('POST', echoUrl);
 
     expect(
         client.send(request).then((response) {
@@ -28,10 +28,10 @@ void main() {
   test('#send with an invalid URL', () {
     var client = BrowserClient();
     var url = Uri.parse('http://http.invalid');
-    var request = http.StreamedRequest("POST", url);
+    var request = http.StreamedRequest('POST', url);
 
     expect(
-        client.send(request), throwsClientException("XMLHttpRequest error."));
+        client.send(request), throwsClientException('XMLHttpRequest error.'));
 
     request.sink.add('{"hello": "world"}'.codeUnits);
     request.sink.close();
diff --git a/test/io/client_test.dart b/test/io/client_test.dart
@@ -19,7 +19,7 @@ void main() {
     expect(
         startServer().then((_) {
           var client = http.Client();
-          var request = http.StreamedRequest("POST", serverUrl);
+          var request = http.StreamedRequest('POST', serverUrl);
           request.headers[HttpHeaders.contentTypeHeader] =
               'application/json; charset=utf-8';
           request.headers[HttpHeaders.userAgentHeader] = 'Dart';
@@ -58,7 +58,7 @@ void main() {
         startServer().then((_) {
           var ioClient = HttpClient();
           var client = http_io.IOClient(ioClient);
-          var request = http.StreamedRequest("POST", serverUrl);
+          var request = http.StreamedRequest('POST', serverUrl);
           request.headers[HttpHeaders.contentTypeHeader] =
               'application/json; charset=utf-8';
           request.headers[HttpHeaders.userAgentHeader] = 'Dart';
@@ -97,7 +97,7 @@ void main() {
         startServer().then((_) {
           var client = http.Client();
           var url = Uri.parse('http://http.invalid');
-          var request = http.StreamedRequest("POST", url);
+          var request = http.StreamedRequest('POST', url);
           request.headers[HttpHeaders.contentTypeHeader] =
               'application/json; charset=utf-8';
 
diff --git a/test/io/request_test.dart b/test/io/request_test.dart
@@ -14,7 +14,7 @@ void main() {
     expect(
         startServer().then((_) {
           var request = http.Request('POST', serverUrl);
-          request.body = "hello";
+          request.body = 'hello';
           request.headers['User-Agent'] = 'Dart';
 
           expect(
diff --git a/test/io/utils.dart b/test/io/utils.dart
@@ -20,7 +20,7 @@ Uri get serverUrl => Uri.parse('http://localhost:${_server.port}');
 
 /// Starts a new HTTP server.
 Future startServer() {
-  return HttpServer.bind("localhost", 0).then((s) {
+  return HttpServer.bind('localhost', 0).then((s) {
     _server = s;
     s.listen((request) {
       var path = request.uri.path;
@@ -69,7 +69,7 @@ Future startServer() {
         }
 
         response.headers.contentType =
-            ContentType("application", "json", charset: outputEncoding.name);
+            ContentType('application', 'json', charset: outputEncoding.name);
         response.headers.set('single', 'value');
 
         var requestBody;
diff --git a/test/mock_client_test.dart b/test/mock_client_test.dart
@@ -19,7 +19,7 @@ void main() {
     });
 
     expect(
-        client.post("http://example.com/foo", body: {
+        client.post('http://example.com/foo', body: {
           'field1': 'value1',
           'field2': 'value2'
         }).then((response) => response.body),
@@ -39,9 +39,9 @@ void main() {
       });
     });
 
-    var uri = Uri.parse("http://example.com/foo");
-    var request = http.Request("POST", uri);
-    request.body = "hello, world";
+    var uri = Uri.parse('http://example.com/foo');
+    var request = http.Request('POST', uri);
+    request.body = 'hello, world';
     var future = client
         .send(request)
         .then(http.Response.fromStream)
@@ -54,7 +54,7 @@ void main() {
       return Future.value(http.Response('you did it', 200));
     });
 
-    expect(client.read("http://example.com/foo"),
+    expect(client.read('http://example.com/foo'),
         completion(equals('you did it')));
   });
 }
diff --git a/test/multipart_test.dart b/test/multipart_test.dart
@@ -30,9 +30,9 @@ void main() {
     var request = http.MultipartRequest('POST', dummyUrl);
     request.fields['field1'] = 'value1';
     request.fields['field2'] = 'value2';
-    request.files.add(http.MultipartFile.fromString("file1", "contents1",
-        filename: "filename1.txt"));
-    request.files.add(http.MultipartFile.fromString("file2", "contents2"));
+    request.files.add(http.MultipartFile.fromString('file1', 'contents1',
+        filename: 'filename1.txt'));
+    request.files.add(http.MultipartFile.fromString('file2', 'contents2'));
 
     expect(request, bodyMatches('''
         --{{boundary}}
diff --git a/test/request_test.dart b/test/request_test.dart
diff --git a/test/response_test.dart b/test/response_test.dart
diff --git a/test/utils.dart b/test/utils.dart

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ abstract class BaseRequest {`
`34`	`34`
`35`	`35`	`set contentLength(int value) {`
`36`	`36`	`if (value != null && value < 0) {`
`37`		`- throw ArgumentError("Invalid content length $value.");`
	`37`	`+ throw ArgumentError('Invalid content length $value.');`
`38`	`38`	`}`
`39`	`39`	`_checkFinalized();`
`40`	`40`	`_contentLength = value;`
Original file line number	Diff line number	Diff line change
`@@ -44,9 +44,9 @@ abstract class BaseResponse {`
`44`	`44`	`this.persistentConnection = true,`
`45`	`45`	`this.reasonPhrase}) {`
`46`	`46`	`if (statusCode < 100) {`
`47`		`- throw ArgumentError("Invalid status code $statusCode.");`
	`47`	`+ throw ArgumentError('Invalid status code $statusCode.');`
`48`	`48`	`} else if (contentLength != null && contentLength < 0) {`
`49`		`- throw ArgumentError("Invalid content length $contentLength.");`
	`49`	`+ throw ArgumentError('Invalid content length $contentLength.');`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,5 +82,5 @@ Encoding _encodingForHeaders(Map<String, String> headers) =>`
`82`	`82`	`MediaType _contentTypeForHeaders(Map<String, String> headers) {`
`83`	`83`	`var contentType = headers['content-type'];`
`84`	`84`	`if (contentType != null) return MediaType.parse(contentType);`
`85`		`- return MediaType("application", "octet-stream");`
	`85`	`+ return MediaType('application', 'octet-stream');`
`86`	`86`	`}`