[http2] Gracefully receive headers on canceled streams #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a client opens a stream and then cancels it, the server may have already sent response frames back. The HTTP/2 spec says that the client MUST be prepared to receive any such frames. We already handle this correctly for data frames, but prior to this patch, header frames on a canceled stream would cause the whole connection to be torn down. This patch fixes that. Fixes dart-lang#1799. Test Plan: Unit tests included. Before this change, the new test would fail with "Connection is being forcefully terminated. (errorCode: 1)". wchargin-branch: http2-headers-after-cancel wchargin-source: 428af2c7cf2fc9f18884558e2b471d2d29a05998
wchargin-branch: http2-headers-after-cancel wchargin-source: 8aed54b8d5bcc0450db8f46ab08a8012f4de1bd8
|
Hello! This is my first time writing Dart code. I tried to follow local style, and ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client opens a stream and then cancels it, the server may have already sent response frames back. The HTTP/2 spec says that the client MUST be prepared to receive any such frames. We already handle this correctly for data frames, but prior to this patch, header frames on a canceled stream would cause the whole connection to be torn down. This patch fixes that.
Fixes #1799.
Test Plan:
Unit tests included. Before this change, the new test would fail with "Connection is being forcefully terminated. (errorCode: 1)".
wchargin-branch: http2-headers-after-cancel