Change classMemberDeclaration to memberDeclaration
#4531
Merged
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n text about members to have just one kind
lrhn
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny adjustment: We have sort of had separate kinds of member declarations for classes, mixins etc., but we never took the step to actually make them different. This PR changes the language specification such that it just has a
<memberDeclaration>which is then used in the grammar rules for<mixinDeclaration>,<extensionDeclaration>etc.This means that it is not a syntax error but an ad-hoc check on the resulting AST when a given member declaration isn't allowed in a specific kind of membered declaration. However, that's the way this is implemented already, so there is no implementation effort associated with this change.