[jnigen] Switch to package:dart_flutter_team_lints (#1279)

Author: dcharkes

pkgs/jni/CHANGELOG.md

@@ -89,6 +89,7 @@
 ## 0.7.2
 
 - Fixed a bug where reading non-null terminated strings would overflow.
+- Use `package:dart_flutter_team_lints`.
 
 ## 0.7.1
 

pkgs/jni/analysis_options.yaml

@@ -1,16 +1,30 @@
-include: package:flutter_lints/flutter.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
   errors:
     todo: ignore
   exclude: [build/**, third_party/**]
   language:
+    strict-casts: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    strict-inference: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
     strict-raw-types: true
 
 linter:
   rules:
-    - dangling_library_doc_comments
-    - prefer_final_locals
-    - prefer_const_declarations
-# Additional information about this file can be found at
-# https://dart.dev/guides/language/analysis-options
+    dangling_library_doc_comments: true
+    prefer_final_locals: true
+    prefer_const_declarations: true
+    avoid_catching_errors: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    avoid_dynamic_calls: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    collection_methods_unrelated_type: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    comment_references: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    directives_ordering: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    lines_longer_than_80_chars: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    omit_local_variable_types: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    only_throw_errors: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    prefer_relative_imports: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    prefer_single_quotes: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    type_annotate_public_apis: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    unnecessary_parenthesis: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    unreachable_from_main: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    use_super_parameters: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.

pkgs/jni/example/pubspec.lock

@@ -200,7 +200,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "0.9.3-wip"
+    version: "0.9.3"
   js:
     dependency: transitive
     description:
@@ -213,18 +213,18 @@ packages:
     dependency: transitive
     description:
       name: leak_tracker
-      sha256: "7f0df31977cb2c0b88585095d168e689669a2cc9b97c309665e3386f3e9d341a"
+      sha256: "3f87a60e8c63aecc975dda1ceedbc8f24de75f09e4856ea27daf8958f2f0ce05"
       url: "https://pub.dev"
     source: hosted
-    version: "10.0.4"
+    version: "10.0.5"
   leak_tracker_flutter_testing:
     dependency: transitive
     description:
       name: leak_tracker_flutter_testing
-      sha256: "06e98f569d004c1315b991ded39924b21af84cf14cc94791b8aea337d25b57f8"
+      sha256: "932549fb305594d82d7183ecd9fa93463e9914e1b67cacc34bc40906594a1806"
       url: "https://pub.dev"
     source: hosted
-    version: "3.0.3"
+    version: "3.0.5"
   leak_tracker_testing:
     dependency: transitive
     description:
@@ -261,18 +261,18 @@ packages:
     dependency: transitive
     description:
       name: material_color_utilities
-      sha256: "0e0a020085b65b6083975e499759762399b4475f766c21668c4ecca34ea74e5a"
+      sha256: f7142bb1154231d7ea5f96bc7bde4bda2a0945d2806bb11670e30b850d56bdec
       url: "https://pub.dev"
     source: hosted
-    version: "0.8.0"
+    version: "0.11.1"
   meta:
     dependency: transitive
     description:
       name: meta
-      sha256: "7687075e408b093f36e6bbf6c91878cc0d4cd10f409506f7bc996f68220b9136"
+      sha256: bdb68674043280c3428e9ec998512fb681678676b3c54e773629ffe74419f8c7
       url: "https://pub.dev"
     source: hosted
-    version: "1.12.0"
+    version: "1.15.0"
   mime:
     dependency: transitive
     description:
@@ -309,10 +309,10 @@ packages:
     dependency: transitive
     description:
       name: platform
-      sha256: "12220bb4b65720483f8fa9450b4332347737cf8213dd2840d8b2c823e47243ec"
+      sha256: "9b71283fc13df574056616011fb138fd3b793ea47cc509c189a6c3fa5f8a1a65"
       url: "https://pub.dev"
     source: hosted
-    version: "3.1.4"
+    version: "3.1.5"
   plugin_platform_interface:
     dependency: transitive
     description:
@@ -450,26 +450,26 @@ packages:
     dependency: "direct dev"
     description:
       name: test
-      sha256: "7ee446762c2c50b3bd4ea96fe13ffac69919352bd3b4b17bac3f3465edc58073"
+      sha256: "7ee44229615f8f642b68120165ae4c2a75fe77ae2065b1e55ae4711f6cf0899e"
       url: "https://pub.dev"
     source: hosted
-    version: "1.25.2"
+    version: "1.25.7"
   test_api:
     dependency: transitive
     description:
       name: test_api
-      sha256: "9955ae474176f7ac8ee4e989dadfb411a58c30415bcfb648fa04b2b8a03afa7f"
+      sha256: "5b8a98dafc4d5c4c9c72d8b31ab2b23fc13422348d2997120294d3bac86b4ddb"
       url: "https://pub.dev"
     source: hosted
-    version: "0.7.0"
+    version: "0.7.2"
   test_core:
     dependency: transitive
     description:
       name: test_core
-      sha256: "2bc4b4ecddd75309300d8096f781c0e3280ca1ef85beda558d33fcbedc2eead4"
+      sha256: "55ea5a652e38a1dfb32943a7973f3681a60f872f8c3a05a14664ad54ef9c6696"
       url: "https://pub.dev"
     source: hosted
-    version: "0.6.0"
+    version: "0.6.4"
   typed_data:
     dependency: transitive
     description:
@@ -490,10 +490,10 @@ packages:
     dependency: transitive
     description:
       name: vm_service
-      sha256: "3923c89304b715fb1eb6423f017651664a03bf5f4b29983627c4da791f74a4ec"
+      sha256: f652077d0bdf60abe4c1f6377448e8655008eef28f128bc023f7b5e8dfeb48fc
       url: "https://pub.dev"
     source: hosted
-    version: "14.2.1"
+    version: "14.2.4"
   watcher:
     dependency: transitive
     description:

pkgs/jni/lib/jni.dart

@@ -62,7 +62,7 @@ library jni;
 
 export 'dart:ffi' show nullptr;
 
-export 'package:ffi/ffi.dart' show using, Arena;
+export 'package:ffi/ffi.dart' show Arena, using;
 
 export 'src/errors.dart';
 export 'src/jarray.dart';

pkgs/jni/pubspec.yaml

@@ -19,19 +19,20 @@ environment:
   flutter: '>=2.11.0'
 
 dependencies:
+  args: ^2.3.1
   collection: ^1.0.0
-  plugin_platform_interface: ^2.0.2
   ffi: ^2.0.1
-  path: ^1.8.0
   package_config: ^2.1.0
-  args: ^2.3.1
+  path: ^1.8.0
+  plugin_platform_interface: ^2.0.2
 
 dev_dependencies:
+  dart_flutter_team_lints: ^2.0.0
   ## Pin ffigen version because we are depending on internal APIs.
   ffigen: 8.0.2
   flutter_lints: ^2.0.0
-  test: ^1.21.1
   logging: ^1.1.1
+  test: ^1.21.1
 
 # The following section is specific to Flutter packages.
 flutter:

pkgs/jni/test/load_test.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @Tags(['load_test'])
+library;
 
 import 'dart:io';
 import 'dart:ffi';

pkgs/jnigen/CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 0.10.0-wip
 
 - Added support for Kotlin's top-level functions and fields.
+- Use `package:dart_flutter_team_lints`.
 
 ## 0.9.3
 

pkgs/jnigen/analysis_options.yaml

@@ -2,21 +2,34 @@
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
-include: package:lints/recommended.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
   errors:
     todo: ignore
   exclude: [build/**, example/**]
   language:
-    strict-raw-types: true
+    strict-casts: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
     strict-inference: true
+    strict-raw-types: true
 
 linter:
   rules:
-    - dangling_library_doc_comments
-    - prefer_final_locals
-    - prefer_const_declarations
-    - unawaited_futures
-    - prefer_const_constructors
-    - prefer_relative_imports
+    dangling_library_doc_comments: true
+    prefer_final_locals: true
+    prefer_const_declarations: true
+    unawaited_futures: true
+    prefer_const_constructors: true
+    prefer_relative_imports: true
+    avoid_catching_errors: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    comment_references: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    directives_ordering: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    library_annotations: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    lines_longer_than_80_chars: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    omit_local_variable_types: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    only_throw_errors: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    prefer_single_quotes: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    type_annotate_public_apis: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    unnecessary_lambdas: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    unnecessary_parenthesis: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
+    unreachable_from_main: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.

pkgs/jnigen/lib/tools.dart

@@ -2,6 +2,4 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library jnigen_tools;
-
 export 'src/tools/tools.dart';

pkgs/jnigen/pubspec.yaml

@@ -18,20 +18,20 @@ topics:
   - jni
 
 dependencies:
+  args: ^2.3.0
+  cli_config: '>=0.1.0 <0.3.0'
   json_annotation: ^4.8.0
+  logging: ^1.0.2
+  meta: ^1.8.0
   package_config: ^2.1.0
   path: ^1.8.0
   pub_semver: ^2.1.4
-  args: ^2.3.0
   yaml: ^3.1.0
-  logging: ^1.0.2
-  meta: ^1.8.0
-  cli_config: '>=0.1.0 <0.3.0'
 
 dev_dependencies:
-  lints: ^3.0.0
+  build_runner: ^2.2.0
+  dart_flutter_team_lints: ^2.0.0
   jni:
     path: ../jni
-  test: ^1.24.1
-  build_runner: ^2.2.0
   json_serializable: ^6.6.0
+  test: ^1.24.1