-
Notifications
You must be signed in to change notification settings - Fork 81
[jnigen] Change typeclass names and remove API leaks #2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
9c7c786
to
6d13bef
Compare
liamappelbe
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jni.env
internal. We're not even using it in the JNIgen generated bindings. If users want to have a functionality here, they can open an issue. Making this internal heavily discourages use.Foo
will have two typeclasses:$Foo$NullableType$
and$Foo$Type$
including the classes inpackage:jni
itself.jni_symbols.yaml
(this will be changed again after jnigen transformation PR lands but wanted to land this first to make that PR a bit smaller)JObjType
toJType
and make it not internal.JType
used to be the union of both primitive types and non-primitive types, however that is rarely used and internal so renamed that toJTypeBase
and renamed the commonly usedJObjType
toJType
.