Skip to content

Conversation

goderbauer
Copy link
Contributor

@goderbauer goderbauer commented Oct 6, 2025

Follow-up to #2670.
Related to #1640.

Reworks the in_app_java example to use the Dart API to match the example given in the readme.

Copy link

github-actions bot commented Oct 6, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@goderbauer goderbauer changed the title [jnigen] migrate in_app_java to Dart API [jnigen] migrate in_app_java example to Dart API Oct 6, 2025
@goderbauer
Copy link
Contributor Author

Of course, I need to update CI. Will do so tomorrow.

Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI is green, LGTM!

),
),
androidSdkConfig: AndroidSdkConfig(addGradleDeps: true),
sourcePath: [packageRoot.resolve('android/app/src/main/java')],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: sourcePath is singular, but the type is a list.

structure: OutputStructure.singleFile,
),
),
androidSdkConfig: AndroidSdkConfig(addGradleDeps: true),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often do we pass this or not? Are we passing this to 90% of our use cases? If yes, should this be the default? And if it's the default, does that require there always is a Gradle project configured? How is this Gradle project configured, always via flutter create?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You either can download and pass the jars or use this option, I don't have data to say 90% or 80%.

Always via flutter create, yes.

@coveralls
Copy link

coveralls commented Oct 7, 2025

Coverage Status

coverage: 81.228% (+0.4%) from 80.804%
when pulling a197397 on goderbauer:reworkjniex
into 0924cb0 on dart-lang:main.

@goderbauer goderbauer merged commit 33a33b2 into dart-lang:main Oct 9, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants