-
Notifications
You must be signed in to change notification settings - Fork 81
[jnigen] migrate in_app_java example to Dart API #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
Of course, I need to update CI. Will do so tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once CI is green, LGTM!
), | ||
), | ||
androidSdkConfig: AndroidSdkConfig(addGradleDeps: true), | ||
sourcePath: [packageRoot.resolve('android/app/src/main/java')], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: sourcePath is singular, but the type is a list.
structure: OutputStructure.singleFile, | ||
), | ||
), | ||
androidSdkConfig: AndroidSdkConfig(addGradleDeps: true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How often do we pass this or not? Are we passing this to 90% of our use cases? If yes, should this be the default? And if it's the default, does that require there always is a Gradle project configured? How is this Gradle project configured, always via flutter create
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You either can download and pass the jars or use this option, I don't have data to say 90% or 80%.
Always via flutter create
, yes.
Follow-up to #2670.
Related to #1640.
Reworks the
in_app_java
example to use the Dart API to match the example given in the readme.