Skip to content

Ignore git error on repository root detection. #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Ignore git error on repository root detection. #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9725842
Ignore git error on repository root detection.
isoos Oct 21, 2024
6e09fb4
Update lib/src/package_analyzer.dart
isoos Oct 24, 2024
2f8f3c2
remove == 0 check
isoos Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 0.22.14

- Fixes issue with local analysis without git repository root.
- Accept `logger` in `PackageAnalyzer.inspectDir` method.

## 0.22.13
Expand Down
12 changes: 7 additions & 5 deletions lib/src/package_analyzer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,14 @@ class PackageAnalyzer {
}

Future<String?> _detectGitRoot(String packageDir) async {
final pr = await runGitIsolated(
['rev-parse', '--show-toplevel'],
workingDirectory: packageDir,
);
if (pr.exitCode == 0) {
try {
final pr = await runGitIsolated(
['rev-parse', '--show-toplevel'],
workingDirectory: packageDir,
);
return pr.stdout.asString.trim();
} on GitToolException catch (_) {
// not in a git directory (or git is broken) - ignore exception
}
return null;
}
Expand Down