Skip to content

Fix pana fails with custom PUB_HOSTED_URL containing a path #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −3
Open

Fix pana fails with custom PUB_HOSTED_URL containing a path #1522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b691da8
Fix custom pub repositories with path could not be used
jakob-grabner Nov 11, 2025
2839fb4
Normalize pub PUB_HOSTED_URL
jakob-grabner Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/src/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,17 @@ Future<void> copyDir(String from, String to) async {
}

Future<String> getVersionListing(String package, {Uri? pubHostedUrl}) async {
final url = (pubHostedUrl ?? Uri.parse('https://pub.dartlang.org')).resolve(
'/api/packages/$package',
);
var url = (pubHostedUrl ?? Uri.parse('https://pub.dartlang.org'))
.normalizePath();
// If we have a path of only `/`
if (url.path == '/') {
url = url.replace(path: '');
}
// If there is a path, and it doesn't end in a slash we normalize to slash
if (url.path.isNotEmpty && !url.path.endsWith('/')) {
url = url.replace(path: '${url.path}/');
}
url = url.resolve('api/packages/$package');
log.fine('Downloading: $url');

return await retry(
Expand Down
Loading