Fix screenshot overwrite bug #1523
Merged
+34
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
approved these changes
Nov 14, 2025
Collaborator
isoos
left a comment
isoos
left a comment
There was a problem hiding this comment.
Let's also mention it in the changelog!
sigurdm
approved these changes
Nov 17, 2025
szakarias
force-pushed
the
sameNameScreenshots
branch
from
28d2d51 to
73266db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved an issue where screenshots sharing the same filename but located in different subdirectories were overwriting each other during processing. The fix ensures that the full path, including the directory sturcture, is maintained for generated screenshot assets, preventing collisions.
Will be used to fix dart-lang/pub-dev#9068