naming

Author: szakarias

pkg/_pub_shared/lib/format/encoding.dart

@@ -6,17 +6,17 @@ import 'dart:convert';
 import 'dart:typed_data';
 
 /// Base64 encodes [dataPoints] as 32-bit unsigned integers serialized with
-/// big endian byte order.
-String encodeIntsAsBigEndianBase64String(List<int> dataPoints) {
+/// little endian byte order.
+String encodeIntsAsLittleEndianBase64String(List<int> dataPoints) {
   final byteData = ByteData(4 * dataPoints.length);
   for (int i = 0; i < dataPoints.length; i++) {
     byteData.setUint32(4 * i, dataPoints[i], Endian.little);
   }
   return base64Encode(byteData.buffer.asUint8List());
 }
 
-/// Counter part to [encodeIntsAsBigEndianBase64String].
-List<int> decodeIntsFromBigEndianBase64String(String encoded) {
+/// Counter part to [encodeIntsAsLittleEndianBase64String].
+List<int> decodeIntsFromLittleEndianBase64String(String encoded) {
   final bytes = base64Decode(encoded);
   final resLength = bytes.length ~/ 4;
   final dataPoints = List.filled(resLength, -1);

pkg/_pub_shared/test/format/encoding_test.dart

@@ -8,22 +8,22 @@ import 'package:test/test.dart';
 void main() {
   test('encode/decode success', () {
     final data = [1, 2, 3, 4, 5, 6, 7, 8, 9];
-    final encoded = encodeIntsAsBigEndianBase64String(data);
+    final encoded = encodeIntsAsLittleEndianBase64String(data);
     expect(encoded, 'AQAAAAIAAAADAAAABAAAAAUAAAAGAAAABwAAAAgAAAAJAAAA');
-    expect(decodeIntsFromBigEndianBase64String(encoded), data);
+    expect(decodeIntsFromLittleEndianBase64String(encoded), data);
   });
 
   test('encode/decode empty', () {
     final data = <int>[];
-    final encoded = encodeIntsAsBigEndianBase64String(data);
+    final encoded = encodeIntsAsLittleEndianBase64String(data);
     expect(encoded, '');
-    expect(decodeIntsFromBigEndianBase64String(encoded), data);
+    expect(decodeIntsFromLittleEndianBase64String(encoded), data);
   });
 
   test('encode/decode failure with negative integers', () {
     final data = <int>[-1, -2];
-    final encoded = encodeIntsAsBigEndianBase64String(data);
+    final encoded = encodeIntsAsLittleEndianBase64String(data);
     expect(encoded, '//////7///8=');
-    expect(decodeIntsFromBigEndianBase64String(encoded), isNot(data));
+    expect(decodeIntsFromLittleEndianBase64String(encoded), isNot(data));
   });
 }