Skip to content

Move getting the blobId closer to its actual use. #8087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Move getting the blobId closer to its actual use. #8087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pkg/pub_worker/lib/src/analyze.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,6 @@ Future<void> _analyzePackage(
log.writeln('STOPPED: ${clock.now().toUtc().toIso8601String()}');
}

// Upload results, if there is any
_log.info('api.taskUploadResult("$package", "$version")');
final r = await retry(
() => api.taskUploadResult(package, version),
retryIf: _retryIf,
);

// Create a file to store the blob, and add everything to it.
final blobFile = File(p.join(tempDir.path, 'files.blob'));
final builder = IndexedBlobBuilder(blobFile.openWrite());
Expand Down Expand Up @@ -201,6 +194,13 @@ Future<void> _analyzePackage(
logFile.openRead().transform(gzip.encoder),
);

// Upload results, if there is any
_log.info('api.taskUploadResult("$package", "$version")');
final r = await retry(
() => api.taskUploadResult(package, version),
retryIf: _retryIf,
);

// Create BlobIndex
final index = await builder.buildIndex(r.blobId);

Expand Down
Loading