ReservedPackage + admin action.

[isoos]

• Fixes Admin action for reserving package names #8082

[sigurdm]

Should we add an option to delete the entity? Maybe it is not worth it...

[jonasfj]

We could just add:

• package-reserve-list
• package-reserve-delete

Life is easier, if we split them into multiple actions. We can still put them all in the same file if want that.

We could even consider naming them:
package-reservation-create
package-reservation-list
package-reservation-delete

naming is a nit, but it's probably more intuitive to have separate options. And it's probably easier to read the code too.

[isoos]

Like a --delete flag?

[sigurdm]

Yeah - probably --delete=true as we didn't implement real flags for actions,

[jonasfj]

a separate command is MUCH easier to do.

[jonasfj]

it's really just something like:

final package = options['package'];
InvalidInputException.check(
  package != null && package.isNotEmpty,
  '`package` must be given',
);

await withRetryTransaction(dbService, (tx) async {
  final existing = await tx.lookupOrNull<ReservedPackage>(
      dbService.emptyKey.append(ReservedPackage, id: package));
      
  if (exiting == null) {
    return {'message': 'ReservedPackage for "$package" does not exist!'};
  }
  
  tx.delete(existing.key);
});

return {'message': 'ReservedPackage for "$package" deleted.'};

A --delete=true flag requires a lot more explanation in the documentation, it's not very intuitive.

[jonasfj]

We could just add:

• package-reserve-list
• package-reserve-delete

Life is easier, if we split them into multiple actions. We can still put them all in the same file if want that.

We could even consider naming them:
package-reservation-create
package-reservation-list
package-reservation-delete

naming is a nit, but it's probably more intuitive to have separate options. And it's probably easier to read the code too.

[sigurdm]

Yeah - multiple commands is probably better.

[isoos]

Updated, PTAL.

[isoos]

I will add list/delete in a follow-up PR.