Skip to content

Use md5 hash for etag in mem_storage #8111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Use md5 hash for etag in mem_storage #8111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/fake_gcloud/lib/mem_storage.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import 'dart:async';
import 'dart:convert';

import 'package:_discoveryapis_commons/_discoveryapis_commons.dart';
import 'package:crypto/crypto.dart';
import 'package:gcloud/storage.dart';
import 'package:logging/logging.dart';

Expand Down Expand Up @@ -126,6 +127,8 @@ class _File implements ObjectInfo {
@override
final int crc32CChecksum;
@override
final List<int> md5Hash;
@override
final DateTime updated;
@override
final ObjectMetadata metadata;
Expand All @@ -137,14 +140,15 @@ class _File implements ObjectInfo {
DateTime? updated,
}) : // TODO: use a real CRC32 check
crc32CChecksum = content.fold<int>(0, (a, b) => a + b) & 0xffffffff,
md5Hash = md5.convert(content).bytes,
updated = updated ?? DateTime.now().toUtc(),
metadata = ObjectMetadata(acl: Acl([]));

@override
Uri get downloadLink => Uri(scheme: 'gs', host: bucketName, path: name);

@override
String get etag => crc32CChecksum.toRadixString(16);
String get etag => md5Hash.toString();

@override
ObjectGeneration get generation {
Expand All @@ -154,9 +158,6 @@ class _File implements ObjectInfo {

@override
int get length => content.length;

@override
List<int> get md5Hash => etag.codeUnits;
}

class _Bucket implements Bucket {
Expand Down
Loading