Download counts: cache 30-days totals in backend #8117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Oct 7, 2024
| await announcementBackend.start(); | ||
| await topPackages.start(); | ||
| await youtubeBackend.start(); | ||
| await downloadCountsBackend.start(); |
Member
There was a problem hiding this comment.
@isoos is this this the right place to start it?
unrelated: Should we investigate if these could be started concurrently?
Collaborator
There was a problem hiding this comment.
I think it is a good place to start it, unless we only want to start it in the default and not in the others.
isoos
reviewed
Oct 7, 2024
| try { | ||
| final info = await storageService | ||
| .bucket(activeConfiguration.reportsBucketName!) | ||
| .info(downloadCounts30DaysTotalsFileName); |
Collaborator
There was a problem hiding this comment.
IIRC we have a tryInfo in the lib/shared/storage.dart which could at least handle the 404 part of the exceptions.
isoos
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.