CSS rename/migration: neutral text color. #8124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
approved these changes
Oct 10, 2024
isoos
force-pushed
the
migrate-neutral-text
branch
from
ce0b683 to
848ecd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the neutral and the inset text color is the same, I'm migrating them in separate steps, esp. because e.g. in the
_detail_page.scssI needed to match the role choice (e.g. not mix the inset background with the neutral text color, unless it is intentional).Dark theme changes:
#e0e0e0using the#dcdcdc(gainsboro) gray, which is the closes named color