Skip to content

Lookup SDK versions concurrently #8165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Lookup SDK versions concurrently #8165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions app/lib/package/backend.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,13 +1073,12 @@ class PackageBackend {
}) async {
final sw = Stopwatch()..start();
final newVersion = entities.packageVersion;
final currentDartSdk = await getCachedDartSdkVersion(
lastKnownStable: toolStableDartSdkVersion);
final currentFlutterSdk = await getCachedFlutterSdkVersion(
lastKnownStable: toolStableFlutterSdkVersion);
final [currentDartSdk, currentFlutterSdk] = await Future.wait([
getCachedDartSdkVersion(lastKnownStable: toolStableDartSdkVersion),
getCachedFlutterSdkVersion(lastKnownStable: toolStableFlutterSdkVersion),
]);
final existingPackage = await lookupPackage(newVersion.package);
final isNew = existingPackage == null;

// check authorizations before the transaction
await _requireUploadAuthorization(
agent, existingPackage, newVersion.version!);
Expand All @@ -1102,14 +1101,12 @@ class PackageBackend {
throw AssertionError(
'Package "${newVersion.package}" has no admin email to notify.');
}

// check rate limits before the transaction
await verifyPackageUploadRateLimit(
agent: agent,
package: newVersion.package,
isNew: isNew,
);

final email = createPackageUploadedEmail(
packageName: newVersion.package,
packageVersion: newVersion.version!,
Expand All @@ -1118,7 +1115,6 @@ class PackageBackend {
uploaderEmails.map((email) => EmailAddress(email)).toList(),
);
final outgoingEmail = emailBackend.prepareEntity(email);

Package? package;
final existingVersions = await db
.query<PackageVersion>(ancestorKey: newVersion.packageKey!)
Expand Down
Loading